diff options
| author | Ben Noordhuis <info@bnoordhuis.nl> | 2018-03-30 12:47:02 +0200 |
|---|---|---|
| committer | Ruben Bridgewater <ruben@bridgewater.de> | 2018-04-10 00:53:20 +0200 |
| commit | a6db6404ff200ab37b69a33fad48cb6fa73d8bc8 (patch) | |
| tree | 1a5f470e42f8a1f1a6d2f91102dfa3518c9fe92c /common.gypi | |
| parent | a892d9a0c1facba70753398a41d9dbd74ba83396 (diff) | |
| download | android-node-v8-a6db6404ff200ab37b69a33fad48cb6fa73d8bc8.tar.gz android-node-v8-a6db6404ff200ab37b69a33fad48cb6fa73d8bc8.tar.bz2 android-node-v8-a6db6404ff200ab37b69a33fad48cb6fa73d8bc8.zip | |
deps: cherry-pick b767cde1e7 from upstream V8
Original commit message:
[intl] unbreak build with ICU 57
Remove a call to `icu::toUCharPtr()` that wasn't present in other
similar looking call sites either, just reinterpret_cast directly.
Fixes https://github.com/nodejs/node/issues/19656.
Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng
Change-Id: If281ce0a39356aa8bd20efb24c3e4b52b06841a3
Reviewed-on: https://chromium-review.googlesource.com/987953
Reviewed-by: Daniel Ehrenberg <littledan@chromium.org>
Commit-Queue: Ben Noordhuis <info@bnoordhuis.nl>
Cr-Commit-Position: refs/heads/master@{#52311}
PR-URL: https://github.com/nodejs/node/pull/19710
Fixes: https://github.com/nodejs/node/issues/19656
Refs: https://github.com/v8/v8/commit/b767cde1e7bb94b3fea13f2d7e10cd90e6813d6c
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Steven R Loomis <srloomis@us.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'common.gypi')
| -rw-r--r-- | common.gypi | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/common.gypi b/common.gypi index 2d2bc4f5d5..7953404fae 100644 --- a/common.gypi +++ b/common.gypi @@ -27,7 +27,7 @@ # Reset this number to 0 on major V8 upgrades. # Increment by one for each non-official patch applied to deps/v8. - 'v8_embedder_string': '-node.5', + 'v8_embedder_string': '-node.6', # Enable disassembler for `--print-code` v8 options 'v8_enable_disassembler': 1, |