diff options
| author | Ben Noordhuis <info@bnoordhuis.nl> | 2016-04-28 23:43:02 +0200 |
|---|---|---|
| committer | James M Snell <jasnell@gmail.com> | 2016-04-28 20:35:15 -0700 |
| commit | a5012a04ba2baa1e45ad78abbf5c8e14b4d738e8 (patch) | |
| tree | 1a6ad1fee72527ffd24bc1c794627653db7eab25 /common.gypi | |
| parent | 6c49714df0611c08f0fd27162193893bc1792a92 (diff) | |
| download | android-node-v8-a5012a04ba2baa1e45ad78abbf5c8e14b4d738e8.tar.gz android-node-v8-a5012a04ba2baa1e45ad78abbf5c8e14b4d738e8.tar.bz2 android-node-v8-a5012a04ba2baa1e45ad78abbf5c8e14b4d738e8.zip | |
build: unbreak -prof, disable PIE on OS X
Commit 204f3a8 ("build: Bump MACOSX_DEPLOYMENT_TARGET to 10.7")
unwittingly turned on new ASLR features that make `-prof` unusable for
profiling C++ code, breaking `test/parallel/test-tick-processor.js` in
the process. Build with `-Wl,-no_pie` for now.
Fixes: https://github.com/nodejs/node/issues/5903
PR-URL: https://github.com/nodejs/node/pull/6453
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Diffstat (limited to 'common.gypi')
| -rw-r--r-- | common.gypi | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/common.gypi b/common.gypi index 4174e8c362..10da7abccc 100644 --- a/common.gypi +++ b/common.gypi @@ -325,7 +325,12 @@ }, 'target_conditions': [ ['_type!="static_library"', { - 'xcode_settings': {'OTHER_LDFLAGS': ['-Wl,-search_paths_first']}, + 'xcode_settings': { + 'OTHER_LDFLAGS': [ + '-Wl,-no_pie', + '-Wl,-search_paths_first', + ], + }, }], ], 'conditions': [ |