diff options
| author | Benjamin Coe <bencoe@google.com> | 2019-08-29 07:31:26 -0700 |
|---|---|---|
| committer | Benjamin Coe <bencoe@google.com> | 2019-08-30 07:03:49 -0700 |
| commit | 8f33053dbfc4078812f6b4b551cc9a2e6964b985 (patch) | |
| tree | 46c31ebd2f7301e4803ee0c99bdba388a0039d8d /common.gypi | |
| parent | 858db73a746c7b483f5caa416cd7aef82ba9af8a (diff) | |
| download | android-node-v8-8f33053dbfc4078812f6b4b551cc9a2e6964b985.tar.gz android-node-v8-8f33053dbfc4078812f6b4b551cc9a2e6964b985.tar.bz2 android-node-v8-8f33053dbfc4078812f6b4b551cc9a2e6964b985.zip | |
deps: V8: cherry-pick 597f885
Original commit message:
[coverage] Deterministically sort collected shared function infos
Prior to this CL, collected shared function infos with identical
source ranges were sorted non-deterministically during coverage
collection. This lead to non-deterministically incorrectly-reported
coverage due to an optimization which depended on the sort order later
on.
With this CL, we now sort shared function infos by the source range
*and* call count.
Bug: v8:6000,v8:9212
Change-Id: If8bf900727591e71dbd0df621e472a4303f3a353
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1771776
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Jakob Gruber <jgruber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#63411}
Refs: https://github.com/v8/v8/commit/597f885eaa6189f8c8466ee9916763c679e84e9a
PR-URL: https://github.com/nodejs/node/pull/29367
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Diffstat (limited to 'common.gypi')
| -rw-r--r-- | common.gypi | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/common.gypi b/common.gypi index 5ea3e36506..ca1f853172 100644 --- a/common.gypi +++ b/common.gypi @@ -39,7 +39,7 @@ # Reset this number to 0 on major V8 upgrades. # Increment by one for each non-official patch applied to deps/v8. - 'v8_embedder_string': '-node.11', + 'v8_embedder_string': '-node.12', ##### V8 defaults for Node.js ##### |