diff options
| author | Ben Noordhuis <info@bnoordhuis.nl> | 2015-05-04 20:32:31 +0200 |
|---|---|---|
| committer | Ben Noordhuis <info@bnoordhuis.nl> | 2015-05-04 20:53:29 +0200 |
| commit | 69581b2767766353e496bd98f91d4701a6014254 (patch) | |
| tree | 4f3310b903af0da08e0d162a38450f06b371fac1 /common.gypi | |
| parent | ca219b00d163254f866e3287f690845d437b993a (diff) | |
| download | android-node-v8-69581b2767766353e496bd98f91d4701a6014254.tar.gz android-node-v8-69581b2767766353e496bd98f91d4701a6014254.tar.bz2 android-node-v8-69581b2767766353e496bd98f91d4701a6014254.zip | |
build: don't compile debug build with -Og
It's not supported by clang and commit e67542a ("build: disable -Og
when building with clang") is not sufficient because the configure
script no longer writes the 'clang' variable to common.gypi.
I could fix the configure script but I don't care enough actually do
so. A fixed configure script won't help anyway when the compiler is
overridden through the CXX environment variable at compile time.
PR-URL: https://github.com/iojs/io.js/pull/1611
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Diffstat (limited to 'common.gypi')
| -rw-r--r-- | common.gypi | 9 |
1 files changed, 2 insertions, 7 deletions
diff --git a/common.gypi b/common.gypi index 385c3cd30a..ea7779ee09 100644 --- a/common.gypi +++ b/common.gypi @@ -14,7 +14,7 @@ 'node_tag%': '', 'uv_library%': 'static_library', - # Default to -Og for debug builds. + # Default to -O0 for debug builds. 'v8_optimized_debug%': 0, # Enable disassembler for `--print-code` v8 options @@ -54,13 +54,8 @@ 'v8_enable_handle_zapping%': 1, }, 'defines': [ 'DEBUG', '_DEBUG' ], - 'cflags': [ '-g' ], + 'cflags': [ '-g', '-O0' ], 'conditions': [ - ['clang==1', { - 'cflags': [ '-O0' ], # https://llvm.org/bugs/show_bug.cgi?id=20765 - }, { - 'cflags': [ '-Og' ], # Debug-friendly optimizations only. - }], ['target_arch=="x64"', { 'msvs_configuration_platform': 'x64', }], |