diff options
| author | Gabriel Schulhof <gabriel.schulhof@intel.com> | 2019-10-29 18:59:09 -0700 |
|---|---|---|
| committer | Gabriel Schulhof <gabriel.schulhof@intel.com> | 2019-10-31 13:57:24 -0700 |
| commit | 61d61448a91b74f889c33cad54e95f8fdb9d2c61 (patch) | |
| tree | 0a0f080d3e63ca73631bbf1b93860efc34564ab4 /common.gypi | |
| parent | b23b8dc0fab6153ce73019247aa8d0c306ad1fb0 (diff) | |
| download | android-node-v8-61d61448a91b74f889c33cad54e95f8fdb9d2c61.tar.gz android-node-v8-61d61448a91b74f889c33cad54e95f8fdb9d2c61.tar.bz2 android-node-v8-61d61448a91b74f889c33cad54e95f8fdb9d2c61.zip | |
deps: V8: cherry-pick e5dbc95
Original commit message:
[api] Fix handle leak when getting Context embedder data
The `Context::SlowGetAlignedPointerFromEmbedderData()` method returns
a pointer, so the fact that it allocates handles is not obvious to
the caller.
Since this is the slow path anyway, simply add a handle scope inside
of it.
The tests are also modified to perform the same check for the
`Object` equivalent of this method.
Change-Id: I5f03c9a7b70b3a17315609df021606a53c9feb2d
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1879902
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#64583}
Refs: https://github.com/v8/v8/commit/e5dbc95cc0bfbd8a3b6d67b9e4ed920cf3c9fe27
Fixes: https://github.com/nodejs/node/issues/30127
PR-URL: https://github.com/nodejs/node/pull/30130
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Diffstat (limited to 'common.gypi')
| -rw-r--r-- | common.gypi | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/common.gypi b/common.gypi index e6b189f957..211b418f98 100644 --- a/common.gypi +++ b/common.gypi @@ -39,7 +39,7 @@ # Reset this number to 0 on major V8 upgrades. # Increment by one for each non-official patch applied to deps/v8. - 'v8_embedder_string': '-node.17', + 'v8_embedder_string': '-node.18', ##### V8 defaults for Node.js ##### |