summaryrefslogtreecommitdiff
path: root/common.gypi
diff options
context:
space:
mode:
authorbcoe <bencoe@google.com>2019-11-28 14:06:24 -0800
committerbcoe <bencoe@google.com>2019-11-30 12:13:16 -0800
commit596116168a2e2b8dedf31e3d7ca0247fe5c9824b (patch)
tree9fa901a089ee67038fc745e4a7d1d73bbcd347b3 /common.gypi
parent07ba2eb675a4b58f9c43dc2d209d96b0bec2baf3 (diff)
downloadandroid-node-v8-596116168a2e2b8dedf31e3d7ca0247fe5c9824b.tar.gz
android-node-v8-596116168a2e2b8dedf31e3d7ca0247fe5c9824b.tar.bz2
android-node-v8-596116168a2e2b8dedf31e3d7ca0247fe5c9824b.zip
deps: V8: cherry-pick 0dfd9ea51241
Original commit message: [coverage] Fix coverage with default arguments In the presence of default arguments, the body of the function gets wrapped into another block. This caused our trailing-range-after-return optimization to not apply, because the wrapper block had no source range assigned. This CL correctly assignes a source range to that block, which allows already present code to handle it correctly. Note that this is not a real coverage bug; we've just been reporting whitespace as uncovered. We're fixing it for consistency. Originally reported on github.com/bcoe/c8/issues/66 Bug: v8:9952 Change-Id: Iab3905f558eb99126e0dad8072d03d0a312fdcd3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1903430 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by: Toon Verwaest <verwaest@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#64836} Refs: https://github.com/v8/v8/commit/0dfd9ea51241bebf724f2eb8d6d0158a014f866a PR-URL: https://github.com/nodejs/node/pull/30713 Reviewed-By: Michaƫl Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Diffstat (limited to 'common.gypi')
-rw-r--r--common.gypi2
1 files changed, 1 insertions, 1 deletions
diff --git a/common.gypi b/common.gypi
index e063139a7d..54a8d930c4 100644
--- a/common.gypi
+++ b/common.gypi
@@ -39,7 +39,7 @@
# Reset this number to 0 on major V8 upgrades.
# Increment by one for each non-official patch applied to deps/v8.
- 'v8_embedder_string': '-node.22',
+ 'v8_embedder_string': '-node.23',
##### V8 defaults for Node.js #####