diff options
| author | Ujjwal Sharma <usharma1998@gmail.com> | 2019-09-14 09:20:31 +0530 |
|---|---|---|
| committer | Michaël Zasso <targos@protonmail.com> | 2019-11-08 15:46:47 +0100 |
| commit | 54af1e709c32af66602e06f32e3b10a52a813c99 (patch) | |
| tree | 4a5b543af8ffbce2da6e1548b1bf34a1027806d9 /common.gypi | |
| parent | 5c25db3510c97e6a813481a29eadfb66152328f5 (diff) | |
| download | android-node-v8-54af1e709c32af66602e06f32e3b10a52a813c99.tar.gz android-node-v8-54af1e709c32af66602e06f32e3b10a52a813c99.tar.bz2 android-node-v8-54af1e709c32af66602e06f32e3b10a52a813c99.zip | |
deps: patch V8 to run on older XCode versions
Patch V8 (compiler/js-heap-broker.cc) to remove the use of an optional
property, which is a fairly new C++ feature, since that requires a newer
XCode version than the minimum requirement in BUILDING.md and thus
breaks CI.
PR-URL: https://github.com/nodejs/node/pull/29694
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Diffstat (limited to 'common.gypi')
| -rw-r--r-- | common.gypi | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/common.gypi b/common.gypi index 6ce9c5e877..5a2c1bb6fc 100644 --- a/common.gypi +++ b/common.gypi @@ -39,7 +39,7 @@ # Reset this number to 0 on major V8 upgrades. # Increment by one for each non-official patch applied to deps/v8. - 'v8_embedder_string': '-node.2', + 'v8_embedder_string': '-node.3', ##### V8 defaults for Node.js ##### |