diff options
| author | Bert Belder <bertbelder@gmail.com> | 2018-05-24 20:56:18 -0700 |
|---|---|---|
| committer | Joyee Cheung <joyeec9h3@gmail.com> | 2018-05-27 17:28:21 +0800 |
| commit | 4f28015d22c06c8e6a8d25291148525c71b63c94 (patch) | |
| tree | b36b9610c9a207c57e02cb345f12eebfe364a4cd /common.gypi | |
| parent | c241b7d85cdd1ea33baf70b0e16c1f631a223e84 (diff) | |
| download | android-node-v8-4f28015d22c06c8e6a8d25291148525c71b63c94.tar.gz android-node-v8-4f28015d22c06c8e6a8d25291148525c71b63c94.tar.bz2 android-node-v8-4f28015d22c06c8e6a8d25291148525c71b63c94.zip | |
build,win: disable DLL-interface warnings
Compiling node with vcbuild generates 10,000s of these warnings,
originating from v8.h. This makes it impossible to read any other
diagnostic messages.
PR-URL: https://github.com/nodejs/node/pull/20958
Refs: https://github.com/nodejs/node/pull/15570
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Diffstat (limited to 'common.gypi')
| -rw-r--r-- | common.gypi | 16 |
1 files changed, 12 insertions, 4 deletions
diff --git a/common.gypi b/common.gypi index dd11d7af3c..31196e2253 100644 --- a/common.gypi +++ b/common.gypi @@ -236,10 +236,18 @@ 'BufferSecurityCheck': 'true', 'ExceptionHandling': 0, # /EHsc 'SuppressStartupBanner': 'true', - # Disable "warning C4267: conversion from 'size_t' to 'int', - # possible loss of data". Many originate from our dependencies - # and their sheer number drowns out other, more legitimate warnings. - 'DisableSpecificWarnings': ['4267'], + # Disable warnings: + # - "C4251: class needs to have dll-interface" + # - "C4275: non-DLL-interface used as base for DLL-interface" + # Over 10k of these warnings are generated when compiling node, + # originating from v8.h. Most of them are false positives. + # See also: https://github.com/nodejs/node/pull/15570 + # TODO: re-enable when Visual Studio fixes these upstream. + # + # - "C4267: conversion from 'size_t' to 'int'" + # Many any originate from our dependencies, and their sheer number + # drowns out other, more legitimate warnings. + 'DisableSpecificWarnings': ['4251', '4275', '4267'], 'WarnAsError': 'false', }, 'VCLinkerTool': { |