diff options
| author | Matheus Marchini <matheusdot@gmail.com> | 2017-11-03 22:57:18 -0200 |
|---|---|---|
| committer | Refael Ackermann <refack@gmail.com> | 2017-11-27 17:16:37 -0500 |
| commit | 4a7487b171d4e22a8e8879bd424f4f605d44abaf (patch) | |
| tree | e9ebb133c8cc1ef645dda034b04a69e4d4022416 /common.gypi | |
| parent | cc7fe6032163d6980cef949b3eb854993c228a8f (diff) | |
| download | android-node-v8-4a7487b171d4e22a8e8879bd424f4f605d44abaf.tar.gz android-node-v8-4a7487b171d4e22a8e8879bd424f4f605d44abaf.tar.bz2 android-node-v8-4a7487b171d4e22a8e8879bd424f4f605d44abaf.zip | |
build: fix bsd build with gcc
BSD build with GCC was broken because it was checking for the
llvm_version variable on common.gypi, even though llvm wasn't
installed (or needed).
PR-URL: https://github.com/nodejs/node/pull/16737
Fixes: https://github.com/nodejs/node/issues/16257
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Diffstat (limited to 'common.gypi')
| -rw-r--r-- | common.gypi | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/common.gypi b/common.gypi index 7c1813750c..4b1f0377ba 100644 --- a/common.gypi +++ b/common.gypi @@ -418,7 +418,7 @@ }], ['OS=="freebsd"', { 'conditions': [ - ['llvm_version < "4.0"', { + ['"0" < llvm_version < "4.0"', { # Use this flag because on FreeBSD std::pairs copy constructor is non-trivial. # Doesn't apply to llvm 4.0 (FreeBSD 11.1) or later. # Refs: https://lists.freebsd.org/pipermail/freebsd-toolchain/2016-March/002094.html |