diff options
author | Rod Vagg <rod@vagg.org> | 2019-03-01 11:22:06 +1100 |
---|---|---|
committer | Rod Vagg <rod@vagg.org> | 2019-03-12 13:10:52 +1100 |
commit | 2fa8dc47f3f3a548dd78ccb41bf1d082c1628dfb (patch) | |
tree | 6723d381e1ee34c87fc7c51f2ceb6c534862142f /common.gypi | |
parent | e1cd8ac00760eaf62ee9d51b872a6602d3e932ef (diff) | |
download | android-node-v8-2fa8dc47f3f3a548dd78ccb41bf1d082c1628dfb.tar.gz android-node-v8-2fa8dc47f3f3a548dd78ccb41bf1d082c1628dfb.tar.bz2 android-node-v8-2fa8dc47f3f3a548dd78ccb41bf1d082c1628dfb.zip |
build: enable v8's siphash for hash seed creation
Triggers the V8_USE_SIPHASH to switch from the internal custom V8
hash seed generation function to an implementation of SipHash. Final
step needed to clear up HashWick.
PR-URL: https://github.com/nodejs/node/pull/26367
Refs: https://github.com/nodejs/node/issues/23259
Refs: https://darksi.de/12.hashwick-v8-vulnerability/
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yang Guo <yangguo@chromium.org>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Diffstat (limited to 'common.gypi')
-rw-r--r-- | common.gypi | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/common.gypi b/common.gypi index 8f997dca4d..caeac71b5c 100644 --- a/common.gypi +++ b/common.gypi @@ -44,6 +44,9 @@ # Old time default, now explicitly stated. 'v8_use_snapshot': 'true', + # Turn on SipHash for hash seed generation, addresses HashWick + 'v8_use_siphash': 'true', + # These are more relevant for V8 internal development. # Refs: https://github.com/nodejs/node/issues/23122 # Refs: https://github.com/nodejs/node/issues/23167 |