diff options
| author | Anna Henningsen <anna@addaleax.net> | 2019-01-06 01:52:16 +0100 |
|---|---|---|
| committer | Anna Henningsen <anna@addaleax.net> | 2019-01-09 00:31:33 +0100 |
| commit | 63d4cae009e114127e1a80644e4bffc019e2f4a7 (patch) | |
| tree | c80a23e7afb130dd9053b86952eaca3722bc2fd5 /benchmark | |
| parent | 8ec3c350f54933d9237c63dd17a9a24472fce591 (diff) | |
| download | android-node-v8-63d4cae009e114127e1a80644e4bffc019e2f4a7.tar.gz android-node-v8-63d4cae009e114127e1a80644e4bffc019e2f4a7.tar.bz2 android-node-v8-63d4cae009e114127e1a80644e4bffc019e2f4a7.zip | |
worker: remove `--experimental-worker` flag
Having an experimental feature behind a flag makes change
if we are expecting significant breaking changes to its API.
Since the Worker API has been essentially stable since
its initial introduction, and no noticeable doubt about
possibly not keeping the feature around has been voiced,
removing the flag and thereby reducing the barrier to experimentation,
and consequently receiving feedback on the implementation,
seems like a good idea.
PR-URL: https://github.com/nodejs/node/pull/25361
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Diffstat (limited to 'benchmark')
| -rw-r--r-- | benchmark/misc/startup.js | 2 | ||||
| -rw-r--r-- | benchmark/worker/echo.js | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/benchmark/misc/startup.js b/benchmark/misc/startup.js index 1350cd291e..c1c893b001 100644 --- a/benchmark/misc/startup.js +++ b/benchmark/misc/startup.js @@ -10,7 +10,7 @@ const bench = common.createBenchmark(main, { script: ['benchmark/fixtures/require-cachable', 'test/fixtures/semicolon'], mode: ['process', 'worker'] }, { - flags: ['--expose-internals', '--experimental-worker'] // for workers + flags: ['--expose-internals'] }); function spawnProcess(script) { diff --git a/benchmark/worker/echo.js b/benchmark/worker/echo.js index 32c4bddf7d..3e729d0e26 100644 --- a/benchmark/worker/echo.js +++ b/benchmark/worker/echo.js @@ -7,7 +7,7 @@ const bench = common.createBenchmark(main, { payload: ['string', 'object'], sendsPerBroadcast: [1, 10], n: [1e5] -}, { flags: ['--experimental-worker'] }); +}); const workerPath = path.resolve(__dirname, '..', 'fixtures', 'echo.worker.js'); |