diff options
author | Anatoli Papirovski <apapirovski@mac.com> | 2017-12-09 17:32:48 -0500 |
---|---|---|
committer | Anatoli Papirovski <apapirovski@mac.com> | 2017-12-11 18:17:31 -0500 |
commit | 4df7c190bf449e3d0d8877f45bb7490d7a801118 (patch) | |
tree | 73cdeeffc642bb9d93e5685a6fe5992639676482 /benchmark | |
parent | f3aaaa52b738e20192468a5157721c0a62027a16 (diff) | |
download | android-node-v8-4df7c190bf449e3d0d8877f45bb7490d7a801118.tar.gz android-node-v8-4df7c190bf449e3d0d8877f45bb7490d7a801118.tar.bz2 android-node-v8-4df7c190bf449e3d0d8877f45bb7490d7a801118.zip |
benchmark: fix http/simple.js benchmark
autocannon appears to have trouble recognizing URLs that contain true
or false within them. Use 0 or 1 instead to represent the same.
PR-URL: https://github.com/nodejs/node/pull/17583
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Diffstat (limited to 'benchmark')
-rw-r--r-- | benchmark/fixtures/simple-http-server.js | 2 | ||||
-rw-r--r-- | benchmark/http/simple.js | 4 |
2 files changed, 3 insertions, 3 deletions
diff --git a/benchmark/fixtures/simple-http-server.js b/benchmark/fixtures/simple-http-server.js index 5f56bebdaf..d2eda0c085 100644 --- a/benchmark/fixtures/simple-http-server.js +++ b/benchmark/fixtures/simple-http-server.js @@ -34,7 +34,7 @@ module.exports = http.createServer(function(req, res) { const arg = params[2]; const n_chunks = parseInt(params[3], 10); const resHow = params.length >= 5 ? params[4] : 'normal'; - const chunkedEnc = params.length >= 6 && params[5] === 'false' ? false : true; + const chunkedEnc = params.length >= 6 && params[5] === '0' ? false : true; var status = 200; var n, i; diff --git a/benchmark/http/simple.js b/benchmark/http/simple.js index 238cd1885d..544aad4968 100644 --- a/benchmark/http/simple.js +++ b/benchmark/http/simple.js @@ -8,14 +8,14 @@ const bench = common.createBenchmark(main, { len: [4, 1024, 102400], chunks: [1, 4], c: [50, 500], - chunkedEnc: ['true', 'false'], + chunkedEnc: [1, 0], res: ['normal', 'setHeader', 'setHeaderWH'] }); function main(conf) { process.env.PORT = PORT; var server = require('../fixtures/simple-http-server.js') - .listen(process.env.PORT || common.PORT) + .listen(PORT) .on('listening', function() { const path = `/${conf.type}/${conf.len}/${conf.chunks}/${conf.res}/${conf.chunkedEnc}`; |