summaryrefslogtreecommitdiff
path: root/benchmark
diff options
context:
space:
mode:
authorDaniel Bevenius <daniel.bevenius@gmail.com>2018-05-22 12:10:53 +0200
committerDaniel Bevenius <daniel.bevenius@gmail.com>2018-05-24 08:28:02 +0200
commit3294d1bf62d43071f84ed8eff2c2676ade0d3b64 (patch)
tree25d47bfcbca7d686660d039e16a88c82c28ef9d4 /benchmark
parent9a02de7084e3f3c959d1c7e32bda67cc1d7002bd (diff)
downloadandroid-node-v8-3294d1bf62d43071f84ed8eff2c2676ade0d3b64.tar.gz
android-node-v8-3294d1bf62d43071f84ed8eff2c2676ade0d3b64.tar.bz2
android-node-v8-3294d1bf62d43071f84ed8eff2c2676ade0d3b64.zip
src: remove --expose-http2 option
This commit removes the --expose-http2 option. In the code comment it states that this should should be noop through v9.x, and it sounds like it can be removed for 10.x and above. PR-URL: https://github.com/nodejs/node/pull/20887 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaƫl Zasso <targos@protonmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'benchmark')
-rw-r--r--benchmark/http2/headers.js2
-rw-r--r--benchmark/http2/respond-with-fd.js2
-rw-r--r--benchmark/http2/simple.js2
-rw-r--r--benchmark/http2/write.js2
4 files changed, 4 insertions, 4 deletions
diff --git a/benchmark/http2/headers.js b/benchmark/http2/headers.js
index ad1eb50007..beb1d31b71 100644
--- a/benchmark/http2/headers.js
+++ b/benchmark/http2/headers.js
@@ -7,7 +7,7 @@ const bench = common.createBenchmark(main, {
n: [1e3],
nheaders: [0, 10, 100, 1000],
benchmarker: ['h2load']
-}, { flags: ['--no-warnings', '--expose-http2'] });
+}, { flags: ['--no-warnings'] });
function main({ n, nheaders }) {
const http2 = require('http2');
diff --git a/benchmark/http2/respond-with-fd.js b/benchmark/http2/respond-with-fd.js
index cc9992e8ca..3415a9c69f 100644
--- a/benchmark/http2/respond-with-fd.js
+++ b/benchmark/http2/respond-with-fd.js
@@ -11,7 +11,7 @@ const bench = common.createBenchmark(main, {
streams: [100, 200, 1000],
clients: [1, 2],
benchmarker: ['h2load']
-}, { flags: ['--no-warnings', '--expose-http2'] });
+}, { flags: ['--no-warnings'] });
function main({ requests, streams, clients }) {
fs.open(file, 'r', (err, fd) => {
diff --git a/benchmark/http2/simple.js b/benchmark/http2/simple.js
index cf017e6735..f4598b8156 100644
--- a/benchmark/http2/simple.js
+++ b/benchmark/http2/simple.js
@@ -10,7 +10,7 @@ const bench = common.createBenchmark(main, {
streams: [100, 200, 1000],
clients: [1, 2],
benchmarker: ['h2load']
-}, { flags: ['--no-warnings', '--expose-http2'] });
+}, { flags: ['--no-warnings'] });
function main({ requests, streams, clients }) {
const http2 = require('http2');
diff --git a/benchmark/http2/write.js b/benchmark/http2/write.js
index 6fcb1254ca..fc3203c6e5 100644
--- a/benchmark/http2/write.js
+++ b/benchmark/http2/write.js
@@ -7,7 +7,7 @@ const bench = common.createBenchmark(main, {
length: [64 * 1024, 128 * 1024, 256 * 1024, 1024 * 1024],
size: [100000],
benchmarker: ['h2load']
-}, { flags: ['--no-warnings', '--expose-http2'] });
+}, { flags: ['--no-warnings'] });
function main({ streams, length, size }) {
const http2 = require('http2');