diff options
author | MaleDong <maledong_private@qq.com> | 2018-06-22 19:08:58 +0800 |
---|---|---|
committer | Rich Trott <rtrott@gmail.com> | 2018-07-08 12:27:16 -0700 |
commit | a478259af7671fa2794aa030f7790a9d9772be5e (patch) | |
tree | 5053f2598e6f5cd51beefd02f90d912be6b37511 /benchmark/util | |
parent | c18a9d1cb8fe94e39f2826de7edd9c44c9be9ce2 (diff) | |
download | android-node-v8-a478259af7671fa2794aa030f7790a9d9772be5e.tar.gz android-node-v8-a478259af7671fa2794aa030f7790a9d9772be5e.tar.bz2 android-node-v8-a478259af7671fa2794aa030f7790a9d9772be5e.zip |
test,util: add missing tests and conditions
1) Add missing unit tests by `ucs-2` in different kinds of cases.
2) Add missing unit tests by `usc-2` in different kinds of cases.
3) Fix a bug:We cannot find `ucs-2` in `case 5`'s `if` condition after
`toLowerCase()`
PR-URL: https://github.com/nodejs/node/pull/21455
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Diffstat (limited to 'benchmark/util')
-rw-r--r-- | benchmark/util/normalize-encoding.js | 25 |
1 files changed, 17 insertions, 8 deletions
diff --git a/benchmark/util/normalize-encoding.js b/benchmark/util/normalize-encoding.js index 96eab1912d..65cf5b1b0c 100644 --- a/benchmark/util/normalize-encoding.js +++ b/benchmark/util/normalize-encoding.js @@ -4,18 +4,25 @@ const common = require('../common.js'); const assert = require('assert'); const groupedInputs = { - group_common: ['undefined', 'utf8', 'utf-8', 'base64', 'binary', 'latin1'], - group_upper: ['UTF-8', 'UTF8', 'UCS2', 'UTF-16LE', 'UTF16LE', 'BASE64'], - group_uncommon: [ 'foo', '1', 'false', 'undefined', '[]'], + group_common: ['undefined', 'utf8', 'utf-8', 'base64', + 'binary', 'latin1', 'ucs-2', 'usc-2'], + group_upper: ['UTF-8', 'UTF8', 'UCS2', 'UTF-16LE', + 'UTF16LE', 'BASE64', 'UCS-2', 'USC-2'], + group_uncommon: ['foo', '1', 'false', 'undefined', '[]', '{}'], group_misc: ['', 'utf16le', 'usc2', 'hex', 'HEX', 'BINARY'] }; const inputs = [ - '', 'utf8', 'utf-8', 'UTF-8', - 'UTF8', 'Utf8', 'uTf-8', 'utF-8', 'ucs2', - 'UCS2', 'utf16le', 'utf-16le', 'UTF-16LE', 'UTF16LE', + '', + 'utf8', 'utf-8', 'UTF-8', + 'UTF8', 'Utf8', 'uTf-8', 'utF-8', + 'ucs2', 'UCS2', 'UcS2', + 'USC2', 'usc2', 'uSc2', + 'ucs-2', 'UCS-2', 'UcS-2', + 'usc-2', 'USC-2', 'uSc-2', + 'utf16le', 'utf-16le', 'UTF-16LE', 'UTF16LE', 'binary', 'BINARY', 'latin1', 'base64', 'BASE64', - 'hex', 'HEX', 'foo', '1', 'false', 'undefined', '[]']; + 'hex', 'HEX', 'foo', '1', 'false', 'undefined', '[]', '{}']; const bench = common.createBenchmark(main, { input: inputs.concat(Object.keys(groupedInputs)), @@ -42,6 +49,8 @@ function getInput(input) { return [undefined]; case '[]': return [[]]; + case '{}': + return [{}]; default: return [input]; } @@ -53,7 +62,7 @@ function main({ input, n }) { var noDead = ''; bench.start(); - for (var i = 0; i < n; i += 1) { + for (var i = 0; i < n; ++i) { for (var j = 0; j < inputs.length; ++j) { noDead = normalizeEncoding(inputs[j]); } |