summaryrefslogtreecommitdiff
path: root/benchmark/util
diff options
context:
space:
mode:
authorSarah Meyer <sarahsaltrick@gmail.com>2017-10-06 12:58:55 -0700
committerRich Trott <rtrott@gmail.com>2017-10-28 13:56:44 -0700
commit50fe1a840915a22517ffd2c480558409dbfd6677 (patch)
treebfca585a19d684368acd49141248ec7c20f06446 /benchmark/util
parent64aded33ef310ca87e5566239ab2dbd12b1899b9 (diff)
downloadandroid-node-v8-50fe1a840915a22517ffd2c480558409dbfd6677.tar.gz
android-node-v8-50fe1a840915a22517ffd2c480558409dbfd6677.tar.bz2
android-node-v8-50fe1a840915a22517ffd2c480558409dbfd6677.zip
tools, benchmark: test util benchmark
Create a minimal test for the util benchmark files. PR-URL: https://github.com/nodejs/node/pull/16050 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Diffstat (limited to 'benchmark/util')
-rw-r--r--benchmark/util/format.js3
-rw-r--r--benchmark/util/inspect-array.js3
-rw-r--r--benchmark/util/type-check.js7
3 files changed, 11 insertions, 2 deletions
diff --git a/benchmark/util/format.js b/benchmark/util/format.js
index 6f171318ee..5f9c4c3b59 100644
--- a/benchmark/util/format.js
+++ b/benchmark/util/format.js
@@ -21,6 +21,9 @@ const bench = common.createBenchmark(main, {
});
function main({ n, type }) {
+ // For testing, if supplied with an empty type, default to string.
+ type = type || 'string';
+
const [first, second] = inputs[type];
bench.start();
diff --git a/benchmark/util/inspect-array.js b/benchmark/util/inspect-array.js
index 751e2c3c2d..74332d1857 100644
--- a/benchmark/util/inspect-array.js
+++ b/benchmark/util/inspect-array.js
@@ -18,6 +18,9 @@ function main({ n, len, type }) {
var arr = Array(len);
var i, opts;
+ // For testing, if supplied with an empty type, default to denseArray.
+ type = type || 'denseArray';
+
switch (type) {
case 'denseArray_showHidden':
opts = { showHidden: true };
diff --git a/benchmark/util/type-check.js b/benchmark/util/type-check.js
index 1d9a4f30ef..ee8dd7e4ec 100644
--- a/benchmark/util/type-check.js
+++ b/benchmark/util/type-check.js
@@ -29,16 +29,19 @@ const bench = common.createBenchmark(main, {
type: Object.keys(args),
version: ['native', 'js'],
argument: ['true', 'false-primitive', 'false-object'],
- millions: ['5']
+ n: [5e6]
}, {
flags: ['--expose-internals']
});
function main(conf) {
+ // For testing, if supplied with an empty type, default to ArrayBufferView.
+ conf.type = conf.type || 'ArrayBufferView';
+
const util = process.binding('util');
const types = require('internal/util/types');
- const n = (+conf.millions * 1e6) | 0;
+ const n = (+conf.n) | 0;
const func = { native: util, js: types }[conf.version][`is${conf.type}`];
const arg = args[conf.type][conf.argument];