summaryrefslogtreecommitdiff
path: root/benchmark/net
diff options
context:
space:
mode:
authorcjihrig <cjihrig@gmail.com>2018-10-12 12:45:26 -0400
committercjihrig <cjihrig@gmail.com>2018-10-14 13:23:16 -0400
commitff8db70bc2eacf1cc494573bb6e8335b82c9da49 (patch)
tree2328de9cf495cda9adcf2a6de732d99d12d0162a /benchmark/net
parenteeb2c8fcbbd15d42376249d43fec0cda648b9f72 (diff)
downloadandroid-node-v8-ff8db70bc2eacf1cc494573bb6e8335b82c9da49.tar.gz
android-node-v8-ff8db70bc2eacf1cc494573bb6e8335b82c9da49.tar.bz2
android-node-v8-ff8db70bc2eacf1cc494573bb6e8335b82c9da49.zip
benchmark: add common.binding()
Recently, process.binding() was replaced with internalBinding(). However, internalBinding() is not available on older builds of Node, which are often used for benchmarking purposes. This commit adds a common.binding() to the benchmarks to work around the issue. Hopefully, this can be removed in the not too distant future. PR-URL: https://github.com/nodejs/node/pull/23460 Fixes: https://github.com/nodejs/node/issues/23436 Reviewed-By: Michaƫl Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Diffstat (limited to 'benchmark/net')
-rw-r--r--benchmark/net/tcp-raw-c2s.js10
-rw-r--r--benchmark/net/tcp-raw-pipe.js10
-rw-r--r--benchmark/net/tcp-raw-s2c.js10
3 files changed, 18 insertions, 12 deletions
diff --git a/benchmark/net/tcp-raw-c2s.js b/benchmark/net/tcp-raw-c2s.js
index d6666011d5..1f10ae7c83 100644
--- a/benchmark/net/tcp-raw-c2s.js
+++ b/benchmark/net/tcp-raw-c2s.js
@@ -15,10 +15,12 @@ const bench = common.createBenchmark(main, {
}, { flags: [ '--expose-internals', '--no-warnings' ] });
function main({ dur, len, type }) {
- const { internalBinding } = require('internal/test/binding');
- const { TCP, constants: TCPConstants } = process.binding('tcp_wrap');
- const { TCPConnectWrap } = process.binding('tcp_wrap');
- const { WriteWrap } = internalBinding('stream_wrap');
+ const {
+ TCP,
+ TCPConnectWrap,
+ constants: TCPConstants
+ } = common.binding('tcp_wrap');
+ const { WriteWrap } = common.binding('stream_wrap');
const PORT = common.PORT;
const serverHandle = new TCP(TCPConstants.SERVER);
diff --git a/benchmark/net/tcp-raw-pipe.js b/benchmark/net/tcp-raw-pipe.js
index 8203abca6e..16dc6955c4 100644
--- a/benchmark/net/tcp-raw-pipe.js
+++ b/benchmark/net/tcp-raw-pipe.js
@@ -17,10 +17,12 @@ const bench = common.createBenchmark(main, {
});
function main({ dur, len, type }) {
- const { internalBinding } = require('internal/test/binding');
- const { TCP, constants: TCPConstants } = process.binding('tcp_wrap');
- const { TCPConnectWrap } = process.binding('tcp_wrap');
- const { WriteWrap } = internalBinding('stream_wrap');
+ const {
+ TCP,
+ TCPConnectWrap,
+ constants: TCPConstants
+ } = common.binding('tcp_wrap');
+ const { WriteWrap } = common.binding('stream_wrap');
const PORT = common.PORT;
function fail(err, syscall) {
diff --git a/benchmark/net/tcp-raw-s2c.js b/benchmark/net/tcp-raw-s2c.js
index 1e42b311ad..1700d23890 100644
--- a/benchmark/net/tcp-raw-s2c.js
+++ b/benchmark/net/tcp-raw-s2c.js
@@ -17,10 +17,12 @@ const bench = common.createBenchmark(main, {
});
function main({ dur, len, type }) {
- const { internalBinding } = require('internal/test/binding');
- const { TCP, constants: TCPConstants } = process.binding('tcp_wrap');
- const { TCPConnectWrap } = process.binding('tcp_wrap');
- const { WriteWrap } = internalBinding('stream_wrap');
+ const {
+ TCP,
+ TCPConnectWrap,
+ constants: TCPConstants
+ } = common.binding('tcp_wrap');
+ const { WriteWrap } = common.binding('stream_wrap');
const PORT = common.PORT;
const serverHandle = new TCP(TCPConstants.SERVER);