diff options
author | James M Snell <jasnell@gmail.com> | 2018-08-09 13:44:44 -0700 |
---|---|---|
committer | James M Snell <jasnell@gmail.com> | 2018-08-10 07:44:08 -0700 |
commit | b85460498fc24b855efbc2516f8e7cc629e24bb6 (patch) | |
tree | 1be29060003b4b5b6fa0a827f550d62da9ab9f13 /benchmark/misc/trace.js | |
parent | c85933cbd07ec3e32fdb27c4c4ef1aeadc609345 (diff) | |
download | android-node-v8-b85460498fc24b855efbc2516f8e7cc629e24bb6.tar.gz android-node-v8-b85460498fc24b855efbc2516f8e7cc629e24bb6.tar.bz2 android-node-v8-b85460498fc24b855efbc2516f8e7cc629e24bb6.zip |
src: remove old process.binding('trace_events').emit
Remove the older emit and categoryGroupEnabled bindings in
favor of the new intrinsics
PR-URL: https://github.com/nodejs/node/pull/22127
Reviewed-By: Andreas Madsen <amwebdk@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Diffstat (limited to 'benchmark/misc/trace.js')
-rw-r--r-- | benchmark/misc/trace.js | 29 |
1 files changed, 2 insertions, 27 deletions
diff --git a/benchmark/misc/trace.js b/benchmark/misc/trace.js index 7ac80ca4cf..fb51c91e9e 100644 --- a/benchmark/misc/trace.js +++ b/benchmark/misc/trace.js @@ -4,7 +4,7 @@ const common = require('../common.js'); const bench = common.createBenchmark(main, { n: [100000], - method: ['trace', 'emit', 'isTraceCategoryEnabled', 'categoryGroupEnabled'] + method: ['trace', 'isTraceCategoryEnabled'] }, { flags: ['--expose-internals', '--trace-event-categories', 'foo'] }); @@ -13,14 +13,6 @@ const { TRACE_EVENT_PHASE_NESTABLE_ASYNC_BEGIN: kBeforeEvent } = process.binding('constants').trace; -function doEmit(n, emit) { - bench.start(); - for (var i = 0; i < n; i++) { - emit(kBeforeEvent, 'foo', 'test', 0, 'arg1', 1); - } - bench.end(n); -} - function doTrace(n, trace) { bench.start(); for (var i = 0; i < n; i++) { @@ -38,23 +30,12 @@ function doIsTraceCategoryEnabled(n, isTraceCategoryEnabled) { bench.end(n); } -function doCategoryGroupEnabled(n, categoryGroupEnabled) { - bench.start(); - for (var i = 0; i < n; i++) { - categoryGroupEnabled('foo'); - categoryGroupEnabled('bar'); - } - bench.end(n); -} - function main({ n, method }) { const { internalBinding } = require('internal/test/binding'); const { trace, - isTraceCategoryEnabled, - emit, - categoryGroupEnabled + isTraceCategoryEnabled } = internalBinding('trace_events'); switch (method) { @@ -62,15 +43,9 @@ function main({ n, method }) { case 'trace': doTrace(n, trace); break; - case 'emit': - doEmit(n, emit); - break; case 'isTraceCategoryEnabled': doIsTraceCategoryEnabled(n, isTraceCategoryEnabled); break; - case 'categoryGroupEnabled': - doCategoryGroupEnabled(n, categoryGroupEnabled); - break; default: throw new Error(`Unexpected method "${method}"`); } |