summaryrefslogtreecommitdiff
path: root/benchmark/fs
diff options
context:
space:
mode:
authorRuben Bridgewater <ruben@bridgewater.de>2017-12-30 03:57:52 +0100
committerRuben Bridgewater <ruben@bridgewater.de>2018-01-23 01:29:29 +0100
commit7e03ffcc121c0ae137a890c7eb048fd0b303a4a0 (patch)
treee29e9ff452dda8e99cd32581ec184d82d07625af /benchmark/fs
parenta52878c23911df269cd86dbca35d1d75a6468efe (diff)
downloadandroid-node-v8-7e03ffcc121c0ae137a890c7eb048fd0b303a4a0.tar.gz
android-node-v8-7e03ffcc121c0ae137a890c7eb048fd0b303a4a0.tar.bz2
android-node-v8-7e03ffcc121c0ae137a890c7eb048fd0b303a4a0.zip
benchmark: (fs) use destructuring
PR-URL: https://github.com/nodejs/node/pull/18250 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'benchmark/fs')
-rw-r--r--benchmark/fs/bench-readdir.js4
-rw-r--r--benchmark/fs/bench-readdirSync.js4
-rw-r--r--benchmark/fs/bench-realpath.js5
-rw-r--r--benchmark/fs/bench-realpathSync.js5
-rw-r--r--benchmark/fs/bench-stat.js4
-rw-r--r--benchmark/fs/bench-statSync.js4
-rw-r--r--benchmark/fs/read-stream-throughput.js2
-rw-r--r--benchmark/fs/readFileSync.js4
-rw-r--r--benchmark/fs/readfile.js8
-rw-r--r--benchmark/fs/write-stream-throughput.js5
10 files changed, 12 insertions, 33 deletions
diff --git a/benchmark/fs/bench-readdir.js b/benchmark/fs/bench-readdir.js
index eb15e72724..a3e19e242d 100644
--- a/benchmark/fs/bench-readdir.js
+++ b/benchmark/fs/bench-readdir.js
@@ -9,9 +9,7 @@ const bench = common.createBenchmark(main, {
});
-function main(conf) {
- const n = conf.n >>> 0;
-
+function main({ n }) {
bench.start();
(function r(cntr) {
if (cntr-- <= 0)
diff --git a/benchmark/fs/bench-readdirSync.js b/benchmark/fs/bench-readdirSync.js
index 8ba2a6ec49..ef3327163e 100644
--- a/benchmark/fs/bench-readdirSync.js
+++ b/benchmark/fs/bench-readdirSync.js
@@ -9,9 +9,7 @@ const bench = common.createBenchmark(main, {
});
-function main(conf) {
- const n = conf.n >>> 0;
-
+function main({ n }) {
bench.start();
for (var i = 0; i < n; i++) {
fs.readdirSync(path.resolve(__dirname, '../../lib/'));
diff --git a/benchmark/fs/bench-realpath.js b/benchmark/fs/bench-realpath.js
index 881bd0031f..6690d7e87b 100644
--- a/benchmark/fs/bench-realpath.js
+++ b/benchmark/fs/bench-realpath.js
@@ -12,10 +12,7 @@ const bench = common.createBenchmark(main, {
});
-function main(conf) {
- const n = conf.n >>> 0;
- const pathType = conf.pathType;
-
+function main({ n, pathType }) {
bench.start();
if (pathType === 'relative')
relativePath(n);
diff --git a/benchmark/fs/bench-realpathSync.js b/benchmark/fs/bench-realpathSync.js
index 2239d9748a..1c751156f7 100644
--- a/benchmark/fs/bench-realpathSync.js
+++ b/benchmark/fs/bench-realpathSync.js
@@ -14,10 +14,7 @@ const bench = common.createBenchmark(main, {
});
-function main(conf) {
- const n = conf.n >>> 0;
- const pathType = conf.pathType;
-
+function main({ n, pathType }) {
bench.start();
if (pathType === 'relative')
relativePath(n);
diff --git a/benchmark/fs/bench-stat.js b/benchmark/fs/bench-stat.js
index 05910d3fc3..8a401ae0b9 100644
--- a/benchmark/fs/bench-stat.js
+++ b/benchmark/fs/bench-stat.js
@@ -9,9 +9,7 @@ const bench = common.createBenchmark(main, {
});
-function main(conf) {
- const n = conf.n >>> 0;
- const statType = conf.statType;
+function main({ n, statType }) {
var arg;
if (statType === 'fstat')
arg = fs.openSync(__filename, 'r');
diff --git a/benchmark/fs/bench-statSync.js b/benchmark/fs/bench-statSync.js
index 901f3f1bee..bd8754a6c3 100644
--- a/benchmark/fs/bench-statSync.js
+++ b/benchmark/fs/bench-statSync.js
@@ -9,9 +9,7 @@ const bench = common.createBenchmark(main, {
});
-function main(conf) {
- const n = conf.n >>> 0;
- const statSyncType = conf.statSyncType;
+function main({ n, statSyncType }) {
const arg = (statSyncType === 'fstatSync' ?
fs.openSync(__filename, 'r') :
__dirname);
diff --git a/benchmark/fs/read-stream-throughput.js b/benchmark/fs/read-stream-throughput.js
index e0dc7edc05..3af8013272 100644
--- a/benchmark/fs/read-stream-throughput.js
+++ b/benchmark/fs/read-stream-throughput.js
@@ -18,7 +18,7 @@ const bench = common.createBenchmark(main, {
function main(conf) {
encodingType = conf.encodingType;
- size = +conf.size;
+ size = conf.size;
filesize = conf.filesize;
switch (encodingType) {
diff --git a/benchmark/fs/readFileSync.js b/benchmark/fs/readFileSync.js
index 8fd0b50421..c28adeb229 100644
--- a/benchmark/fs/readFileSync.js
+++ b/benchmark/fs/readFileSync.js
@@ -7,9 +7,7 @@ const bench = common.createBenchmark(main, {
n: [60e4]
});
-function main(conf) {
- const n = +conf.n;
-
+function main({ n }) {
bench.start();
for (var i = 0; i < n; ++i)
fs.readFileSync(__filename);
diff --git a/benchmark/fs/readfile.js b/benchmark/fs/readfile.js
index 7c55073fe0..7da7758ed0 100644
--- a/benchmark/fs/readfile.js
+++ b/benchmark/fs/readfile.js
@@ -15,8 +15,7 @@ const bench = common.createBenchmark(main, {
concurrent: [1, 10]
});
-function main(conf) {
- const len = +conf.len;
+function main({ len, dur, concurrent }) {
try { fs.unlinkSync(filename); } catch (e) {}
var data = Buffer.alloc(len, 'x');
fs.writeFileSync(filename, data);
@@ -30,7 +29,7 @@ function main(conf) {
bench.end(reads);
try { fs.unlinkSync(filename); } catch (e) {}
process.exit(0);
- }, +conf.dur * 1000);
+ }, dur * 1000);
function read() {
fs.readFile(filename, afterRead);
@@ -48,6 +47,5 @@ function main(conf) {
read();
}
- var cur = +conf.concurrent;
- while (cur--) read();
+ while (concurrent--) read();
}
diff --git a/benchmark/fs/write-stream-throughput.js b/benchmark/fs/write-stream-throughput.js
index 08f059156f..6fe00cde48 100644
--- a/benchmark/fs/write-stream-throughput.js
+++ b/benchmark/fs/write-stream-throughput.js
@@ -13,10 +13,7 @@ const bench = common.createBenchmark(main, {
size: [2, 1024, 65535, 1024 * 1024]
});
-function main(conf) {
- const dur = +conf.dur;
- const encodingType = conf.encodingType;
- const size = +conf.size;
+function main({ dur, encodingType, size }) {
var encoding;
var chunk;