diff options
| author | Joyee Cheung <joyeec9h3@gmail.com> | 2017-01-11 20:16:25 +0800 |
|---|---|---|
| committer | Joyee Cheung <joyeec9h3@gmail.com> | 2017-01-14 14:57:07 +0800 |
| commit | f18b4632b9ad4e919d07eca731f3df64a69096b9 (patch) | |
| tree | d5c6f645e1269aa074068171a4931f8231f5ecdc /benchmark/compare.R | |
| parent | 2f885e7a4391c5d69e46f0d837fe23b8cbac72f6 (diff) | |
| download | android-node-v8-f18b4632b9ad4e919d07eca731f3df64a69096b9.tar.gz android-node-v8-f18b4632b9ad4e919d07eca731f3df64a69096b9.tar.bz2 android-node-v8-f18b4632b9ad4e919d07eca731f3df64a69096b9.zip | |
benchmark: use "confidence" in output of compare.R
Use the word "confidence" to indicate the confidence level of
the p value so it's easier to understand.
With this change more stars in the output of compare.R means
higher confidence level (lower significance level).
PR-URL: https://github.com/nodejs/node/pull/10737
Refs: https://github.com/nodejs/node/pull/10439
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Andreas Madsen <amwebdk@gmail.com>
Diffstat (limited to 'benchmark/compare.R')
| -rw-r--r-- | benchmark/compare.R | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/benchmark/compare.R b/benchmark/compare.R index b4316ca7f8..3f37cad74a 100644 --- a/benchmark/compare.R +++ b/benchmark/compare.R @@ -46,7 +46,7 @@ statistics = ddply(dat, "name", function(subdat) { improvement = sprintf("%.2f %%", ((new.mu - old.mu) / old.mu * 100)); p.value = NA; - significant = 'NA'; + confidence = 'NA'; # Check if there is enough data to calulate the calculate the p-value if (length(old.rate) > 1 && length(new.rate) > 1) { # Perform a statistics test to see of there actually is a difference in @@ -56,19 +56,19 @@ statistics = ddply(dat, "name", function(subdat) { # Add user friendly stars to the table. There should be at least one star # before you can say that there is an improvement. - significant = ''; + confidence = ''; if (p.value < 0.001) { - significant = '***'; + confidence = '***'; } else if (p.value < 0.01) { - significant = '**'; + confidence = '**'; } else if (p.value < 0.05) { - significant = '*'; + confidence = '*'; } } r = list( improvement = improvement, - significant = significant, + confidence = confidence, p.value = p.value ); return(data.frame(r)); |