diff options
author | juggernaut451 <singhjug1994@gmail.com> | 2018-03-17 20:49:09 +0530 |
---|---|---|
committer | Ruben Bridgewater <ruben@bridgewater.de> | 2018-04-10 00:22:33 +0200 |
commit | b80da63b99dc27fcf9b15b65d7166d427a563b3d (patch) | |
tree | 45b2d9bff120f659df4d3a71afb789d3f8a2721a /benchmark/buffers | |
parent | 28e5c462d4f65dca3d0153a5df314f0d4c5c4a84 (diff) | |
download | android-node-v8-b80da63b99dc27fcf9b15b65d7166d427a563b3d.tar.gz android-node-v8-b80da63b99dc27fcf9b15b65d7166d427a563b3d.tar.bz2 android-node-v8-b80da63b99dc27fcf9b15b65d7166d427a563b3d.zip |
benchmark: changed millions and thousands to n
PR-URL: https://github.com/nodejs/node/pull/18917
Fixes: https://github.com/nodejs/node/issues/18778
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Andreas Madsen <amwebdk@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Diffstat (limited to 'benchmark/buffers')
-rw-r--r-- | benchmark/buffers/buffer-compare-instance-method.js | 25 | ||||
-rw-r--r-- | benchmark/buffers/buffer-compare-offset.js | 9 | ||||
-rw-r--r-- | benchmark/buffers/buffer-compare.js | 9 | ||||
-rw-r--r-- | benchmark/buffers/buffer-read-float.js | 8 | ||||
-rw-r--r-- | benchmark/buffers/buffer-read-with-byteLength.js | 8 | ||||
-rw-r--r-- | benchmark/buffers/buffer-read.js | 9 | ||||
-rw-r--r-- | benchmark/buffers/buffer-write.js | 28 | ||||
-rw-r--r-- | benchmark/buffers/dataview-set.js | 13 |
8 files changed, 53 insertions, 56 deletions
diff --git a/benchmark/buffers/buffer-compare-instance-method.js b/benchmark/buffers/buffer-compare-instance-method.js index a3433803b7..77a3e84fa7 100644 --- a/benchmark/buffers/buffer-compare-instance-method.js +++ b/benchmark/buffers/buffer-compare-instance-method.js @@ -4,11 +4,10 @@ const common = require('../common.js'); const bench = common.createBenchmark(main, { size: [16, 512, 1024, 4096, 16386], args: [1, 2, 3, 4, 5], - millions: [1] + n: [1e6] }); -function main({ millions, size, args }) { - const iter = millions * 1e6; +function main({ n, size, args }) { const b0 = Buffer.alloc(size, 'a'); const b1 = Buffer.alloc(size, 'a'); const b0Len = b0.length; @@ -37,41 +36,41 @@ function main({ millions, size, args }) { case 2: b0.compare(b1, 0); bench.start(); - for (i = 0; i < iter; i++) { + for (i = 0; i < n; i++) { b0.compare(b1, 0); } - bench.end(iter / 1e6); + bench.end(n); break; case 3: b0.compare(b1, 0, b1Len); bench.start(); - for (i = 0; i < iter; i++) { + for (i = 0; i < n; i++) { b0.compare(b1, 0, b1Len); } - bench.end(iter / 1e6); + bench.end(n); break; case 4: b0.compare(b1, 0, b1Len, 0); bench.start(); - for (i = 0; i < iter; i++) { + for (i = 0; i < n; i++) { b0.compare(b1, 0, b1Len, 0); } - bench.end(iter / 1e6); + bench.end(n); break; case 5: b0.compare(b1, 0, b1Len, 0, b0Len); bench.start(); - for (i = 0; i < iter; i++) { + for (i = 0; i < n; i++) { b0.compare(b1, 0, b1Len, 0, b0Len); } - bench.end(iter / 1e6); + bench.end(n); break; default: b0.compare(b1); bench.start(); - for (i = 0; i < iter; i++) { + for (i = 0; i < n; i++) { b0.compare(b1); } - bench.end(iter / 1e6); + bench.end(n); } } diff --git a/benchmark/buffers/buffer-compare-offset.js b/benchmark/buffers/buffer-compare-offset.js index 551fcd2f0c..89cc4427d9 100644 --- a/benchmark/buffers/buffer-compare-offset.js +++ b/benchmark/buffers/buffer-compare-offset.js @@ -4,7 +4,7 @@ const common = require('../common.js'); const bench = common.createBenchmark(main, { method: ['offset', 'slice'], size: [16, 512, 1024, 4096, 16386], - millions: [1] + n: [1e6] }); function compareUsingSlice(b0, b1, len, iter) { @@ -17,13 +17,12 @@ function compareUsingOffset(b0, b1, len, iter) { b0.compare(b1, 1, len, 1, len); } -function main({ millions, size, method }) { - const iter = millions * 1e6; +function main({ n, size, method }) { const fn = method === 'slice' ? compareUsingSlice : compareUsingOffset; bench.start(); fn(Buffer.alloc(size, 'a'), Buffer.alloc(size, 'b'), size >> 1, - iter); - bench.end(millions); + n); + bench.end(n); } diff --git a/benchmark/buffers/buffer-compare.js b/benchmark/buffers/buffer-compare.js index f7abb4b3d9..cb4f0f475c 100644 --- a/benchmark/buffers/buffer-compare.js +++ b/benchmark/buffers/buffer-compare.js @@ -24,19 +24,18 @@ const common = require('../common.js'); const bench = common.createBenchmark(main, { size: [16, 512, 1024, 4096, 16386], - millions: [1] + n: [1e6] }); -function main({ millions, size }) { - const iter = millions * 1e6; +function main({ n, size }) { const b0 = Buffer.alloc(size, 'a'); const b1 = Buffer.alloc(size, 'a'); b1[size - 1] = 'b'.charCodeAt(0); bench.start(); - for (var i = 0; i < iter; i++) { + for (var i = 0; i < n; i++) { Buffer.compare(b0, b1); } - bench.end(iter / 1e6); + bench.end(n); } diff --git a/benchmark/buffers/buffer-read-float.js b/benchmark/buffers/buffer-read-float.js index e105642972..dbccf57393 100644 --- a/benchmark/buffers/buffer-read-float.js +++ b/benchmark/buffers/buffer-read-float.js @@ -5,10 +5,10 @@ const bench = common.createBenchmark(main, { type: ['Double', 'Float'], endian: ['BE', 'LE'], value: ['zero', 'big', 'small', 'inf', 'nan'], - millions: [1] + n: [1e6] }); -function main({ millions, type, endian, value }) { +function main({ n, type, endian, value }) { type = type || 'Double'; const buff = Buffer.alloc(8); const fn = `read${type}${endian}`; @@ -32,8 +32,8 @@ function main({ millions, type, endian, value }) { buff[`write${type}${endian}`](values[type][value], 0); bench.start(); - for (var i = 0; i !== millions * 1e6; i++) { + for (var i = 0; i !== n; i++) { buff[fn](0); } - bench.end(millions); + bench.end(n); } diff --git a/benchmark/buffers/buffer-read-with-byteLength.js b/benchmark/buffers/buffer-read-with-byteLength.js index 1858c4fd96..93deab2ab0 100644 --- a/benchmark/buffers/buffer-read-with-byteLength.js +++ b/benchmark/buffers/buffer-read-with-byteLength.js @@ -11,19 +11,19 @@ const types = [ const bench = common.createBenchmark(main, { buffer: ['fast', 'slow'], type: types, - millions: [1], + n: [1e6], byteLength: [1, 2, 3, 4, 5, 6] }); -function main({ millions, buf, type, byteLength }) { +function main({ n, buf, type, byteLength }) { const clazz = buf === 'fast' ? Buffer : require('buffer').SlowBuffer; const buff = new clazz(8); const fn = `read${type || 'IntBE'}`; buff.writeDoubleLE(0, 0); bench.start(); - for (var i = 0; i !== millions * 1e6; i++) { + for (var i = 0; i !== n; i++) { buff[fn](0, byteLength); } - bench.end(millions); + bench.end(n); } diff --git a/benchmark/buffers/buffer-read.js b/benchmark/buffers/buffer-read.js index 88a46cb290..eccbdc507d 100644 --- a/benchmark/buffers/buffer-read.js +++ b/benchmark/buffers/buffer-read.js @@ -21,18 +21,19 @@ const types = [ const bench = common.createBenchmark(main, { buffer: ['fast', 'slow'], type: types, - millions: [1] + n: [1e6] }); -function main({ millions, buf, type }) { +function main({ n, buf, type }) { const clazz = buf === 'fast' ? Buffer : require('buffer').SlowBuffer; const buff = new clazz(8); const fn = `read${type || 'UInt8'}`; buff.writeDoubleLE(0, 0); bench.start(); - for (var i = 0; i !== millions * 1e6; i++) { + + for (var i = 0; i !== n; i++) { buff[fn](0); } - bench.end(millions); + bench.end(n); } diff --git a/benchmark/buffers/buffer-write.js b/benchmark/buffers/buffer-write.js index 297059c192..556423a15c 100644 --- a/benchmark/buffers/buffer-write.js +++ b/benchmark/buffers/buffer-write.js @@ -25,7 +25,7 @@ const types = [ const bench = common.createBenchmark(main, { buffer: ['fast', 'slow'], type: types, - millions: [1] + n: [1e6] }); const INT8 = 0x7f; @@ -60,42 +60,42 @@ const byteLength = { writeIntBE: 6 }; -function main({ millions, buf, type }) { +function main({ n, buf, type }) { const clazz = buf === 'fast' ? Buffer : require('buffer').SlowBuffer; const buff = new clazz(8); const fn = `write${type || 'UInt8'}`; if (!/\d/.test(fn)) - benchSpecialInt(buff, fn, millions); + benchSpecialInt(buff, fn, n); else if (/Int/.test(fn)) - benchInt(buff, fn, millions); + benchInt(buff, fn, n); else - benchFloat(buff, fn, millions); + benchFloat(buff, fn, n); } -function benchInt(buff, fn, millions) { +function benchInt(buff, fn, n) { const m = mod[fn]; bench.start(); - for (var i = 0; i !== millions * 1e6; i++) { + for (var i = 0; i !== n; i++) { buff[fn](i & m, 0); } - bench.end(millions); + bench.end(n); } -function benchSpecialInt(buff, fn, millions) { +function benchSpecialInt(buff, fn, n) { const m = mod[fn]; const byte = byteLength[fn]; bench.start(); - for (var i = 0; i !== millions * 1e6; i++) { + for (var i = 0; i !== n; i++) { buff[fn](i & m, 0, byte); } - bench.end(millions); + bench.end(n); } -function benchFloat(buff, fn, millions) { +function benchFloat(buff, fn, n) { bench.start(); - for (var i = 0; i !== millions * 1e6; i++) { + for (var i = 0; i !== n; i++) { buff[fn](i, 0); } - bench.end(millions); + bench.end(n); } diff --git a/benchmark/buffers/dataview-set.js b/benchmark/buffers/dataview-set.js index ee5acfb1c1..00a7114bdd 100644 --- a/benchmark/buffers/dataview-set.js +++ b/benchmark/buffers/dataview-set.js @@ -20,7 +20,7 @@ const types = [ const bench = common.createBenchmark(main, { type: types, - millions: [1] + n: [1e6] }); const INT8 = 0x7f; @@ -39,18 +39,17 @@ const mod = { setUint32: UINT32 }; -function main({ millions, type }) { +function main({ n, type }) { type = type || 'Uint8'; - const len = millions * 1e6; const ab = new ArrayBuffer(8); const dv = new DataView(ab, 0, 8); const le = /LE$/.test(type); const fn = `set${type.replace(/[LB]E$/, '')}`; if (/int/i.test(fn)) - benchInt(dv, fn, len, le); + benchInt(dv, fn, n, le); else - benchFloat(dv, fn, len, le); + benchFloat(dv, fn, n, le); } function benchInt(dv, fn, len, le) { @@ -60,7 +59,7 @@ function benchInt(dv, fn, len, le) { for (var i = 0; i < len; i++) { method.call(dv, 0, i % m, le); } - bench.end(len / 1e6); + bench.end(len); } function benchFloat(dv, fn, len, le) { @@ -69,5 +68,5 @@ function benchFloat(dv, fn, len, le) { for (var i = 0; i < len; i++) { method.call(dv, 0, i * 0.1, le); } - bench.end(len / 1e6); + bench.end(len); } |