diff options
| author | Andreas Madsen <amwebdk@gmail.com> | 2016-02-08 21:50:10 +0100 |
|---|---|---|
| committer | Rod Vagg <rod@vagg.org> | 2016-02-26 20:29:10 +1100 |
| commit | 15720fa25ad62e1ac497417aaa0e92cc260f9245 (patch) | |
| tree | 55c0954d51d9b101e3c8046a4e9186a5536ac460 /benchmark/buffers/buffer-read.js | |
| parent | f6c505d0b1771d75bd23442e0049ad9581979901 (diff) | |
| download | android-node-v8-15720fa25ad62e1ac497417aaa0e92cc260f9245.tar.gz android-node-v8-15720fa25ad62e1ac497417aaa0e92cc260f9245.tar.bz2 android-node-v8-15720fa25ad62e1ac497417aaa0e92cc260f9245.zip | |
benchmark: fix configuation parameters
The benchmark runner spawns new processes for each configuration. The
specific configuration is transfered by process.argv. This means that
the values have to be parsed. As of right now only numbers and strings
are parsed correctly. However other values such as objects where used.
This fixes the benchmarks that used non-string/number values and
prevents future issues by asserting the type.
PR-URL: https://github.com/nodejs/node/pull/5177
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
Diffstat (limited to 'benchmark/buffers/buffer-read.js')
| -rw-r--r-- | benchmark/buffers/buffer-read.js | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/benchmark/buffers/buffer-read.js b/benchmark/buffers/buffer-read.js index e50de84b04..47affeee79 100644 --- a/benchmark/buffers/buffer-read.js +++ b/benchmark/buffers/buffer-read.js @@ -2,7 +2,7 @@ var common = require('../common.js'); var bench = common.createBenchmark(main, { - noAssert: [false, true], + noAssert: ['false', 'true'], buffer: ['fast', 'slow'], type: ['UInt8', 'UInt16LE', 'UInt16BE', 'UInt32LE', 'UInt32BE', |