summaryrefslogtreecommitdiff
path: root/benchmark/assert
diff options
context:
space:
mode:
authorRich Trott <rtrott@gmail.com>2017-09-03 14:06:09 -0700
committerJames M Snell <jasnell@gmail.com>2017-09-15 15:34:39 -0700
commit3c4c0db26abba8211c0e6d42c14f14b3514b481b (patch)
treeff9ce5b5c1a9fe6374d958bdc8ce51260558c0b3 /benchmark/assert
parent11f46a2586544e71c13e2de9c992ba3e48354a09 (diff)
downloadandroid-node-v8-3c4c0db26abba8211c0e6d42c14f14b3514b481b.tar.gz
android-node-v8-3c4c0db26abba8211c0e6d42c14f14b3514b481b.tar.bz2
android-node-v8-3c4c0db26abba8211c0e6d42c14f14b3514b481b.zip
benchmark: provide default methods for assert
The benchmarks for `assert` all take a `method` configuration option, but the allowable values are different across the files. For each benchmark, provide an arbitrary default if `method` is set to an empty string. This allows all the `assert` benchmarks to be run with a single command but only on a single method. This is primarily useful for testing that the assert benchmark files don't contain egregious errors. (In other words, it's useful for testing.) PR-URL: https://github.com/nodejs/node/pull/15174 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Michaƫl Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'benchmark/assert')
-rw-r--r--benchmark/assert/deepequal-buffer.js2
-rw-r--r--benchmark/assert/deepequal-map.js2
-rw-r--r--benchmark/assert/deepequal-object.js2
-rw-r--r--benchmark/assert/deepequal-prims-and-objs-big-array-set.js2
-rw-r--r--benchmark/assert/deepequal-prims-and-objs-big-loop.js2
-rw-r--r--benchmark/assert/deepequal-set.js2
-rw-r--r--benchmark/assert/deepequal-typedarrays.js2
-rw-r--r--benchmark/assert/throws.js2
8 files changed, 16 insertions, 0 deletions
diff --git a/benchmark/assert/deepequal-buffer.js b/benchmark/assert/deepequal-buffer.js
index 9e86aa231e..d4495af69b 100644
--- a/benchmark/assert/deepequal-buffer.js
+++ b/benchmark/assert/deepequal-buffer.js
@@ -27,6 +27,8 @@ function main(conf) {
data.copy(expectedWrong);
switch (conf.method) {
+ case '':
+ // Empty string falls through to next line as default, mostly for tests.
case 'deepEqual':
bench.start();
for (i = 0; i < n; ++i) {
diff --git a/benchmark/assert/deepequal-map.js b/benchmark/assert/deepequal-map.js
index eae4a20605..4976f26198 100644
--- a/benchmark/assert/deepequal-map.js
+++ b/benchmark/assert/deepequal-map.js
@@ -46,6 +46,8 @@ function main(conf) {
var values, values2;
switch (conf.method) {
+ case '':
+ // Empty string falls through to next line as default, mostly for tests.
case 'deepEqual_primitiveOnly':
values = array.map((_, i) => [`str_${i}`, 123]);
benchmark(assert.deepEqual, n, values);
diff --git a/benchmark/assert/deepequal-object.js b/benchmark/assert/deepequal-object.js
index d1a6cb6994..2efa9452af 100644
--- a/benchmark/assert/deepequal-object.js
+++ b/benchmark/assert/deepequal-object.js
@@ -37,6 +37,8 @@ function main(conf) {
const expectedWrong = createObj(source, '4');
switch (conf.method) {
+ case '':
+ // Empty string falls through to next line as default, mostly for tests.
case 'deepEqual':
bench.start();
for (i = 0; i < n; ++i) {
diff --git a/benchmark/assert/deepequal-prims-and-objs-big-array-set.js b/benchmark/assert/deepequal-prims-and-objs-big-array-set.js
index 1e356cea51..19337d7828 100644
--- a/benchmark/assert/deepequal-prims-and-objs-big-array-set.js
+++ b/benchmark/assert/deepequal-prims-and-objs-big-array-set.js
@@ -53,6 +53,8 @@ function main(conf) {
const expectedWrongSet = new Set(expectedWrong);
switch (conf.method) {
+ case '':
+ // Empty string falls through to next line as default, mostly for tests.
case 'deepEqual_Array':
bench.start();
for (i = 0; i < n; ++i) {
diff --git a/benchmark/assert/deepequal-prims-and-objs-big-loop.js b/benchmark/assert/deepequal-prims-and-objs-big-loop.js
index 2800b51c49..4a345f27c2 100644
--- a/benchmark/assert/deepequal-prims-and-objs-big-loop.js
+++ b/benchmark/assert/deepequal-prims-and-objs-big-loop.js
@@ -34,6 +34,8 @@ function main(conf) {
// Creates new array to avoid loop invariant code motion
switch (conf.method) {
+ case '':
+ // Empty string falls through to next line as default, mostly for tests.
case 'deepEqual':
bench.start();
for (i = 0; i < n; ++i) {
diff --git a/benchmark/assert/deepequal-set.js b/benchmark/assert/deepequal-set.js
index ecf44c063d..aa0ebc0648 100644
--- a/benchmark/assert/deepequal-set.js
+++ b/benchmark/assert/deepequal-set.js
@@ -47,6 +47,8 @@ function main(conf) {
var values, values2;
switch (conf.method) {
+ case '':
+ // Empty string falls through to next line as default, mostly for tests.
case 'deepEqual_primitiveOnly':
values = array.map((_, i) => `str_${i}`);
benchmark(assert.deepEqual, n, values);
diff --git a/benchmark/assert/deepequal-typedarrays.js b/benchmark/assert/deepequal-typedarrays.js
index 6794ced081..8e8cc4b083 100644
--- a/benchmark/assert/deepequal-typedarrays.js
+++ b/benchmark/assert/deepequal-typedarrays.js
@@ -38,6 +38,8 @@ function main(conf) {
var i;
switch (conf.method) {
+ case '':
+ // Empty string falls through to next line as default, mostly for tests.
case 'deepEqual':
bench.start();
for (i = 0; i < n; ++i) {
diff --git a/benchmark/assert/throws.js b/benchmark/assert/throws.js
index 9043799256..075e227f88 100644
--- a/benchmark/assert/throws.js
+++ b/benchmark/assert/throws.js
@@ -22,6 +22,8 @@ function main(conf) {
var i;
switch (conf.method) {
+ case '':
+ // Empty string falls through to next line as default, mostly for tests.
case 'doesNotThrow':
bench.start();
for (i = 0; i < n; ++i) {