diff options
| author | Nikolai Vavilov <vvnicholas@gmail.com> | 2017-02-10 22:21:35 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2017-02-10 22:21:35 +0200 |
| commit | f5ee9921e6de2a984629d04547041d9111cd6ca6 (patch) | |
| tree | fc9903cdc536d4e6b153b5c25b2fcfa47f659386 /benchmark/README.md | |
| parent | b471392f8c6eb8dff24439ded1e51ce6e6710157 (diff) | |
| download | android-node-v8-f5ee9921e6de2a984629d04547041d9111cd6ca6.tar.gz android-node-v8-f5ee9921e6de2a984629d04547041d9111cd6ca6.tar.bz2 android-node-v8-f5ee9921e6de2a984629d04547041d9111cd6ca6.zip | |
benchmark: fix typos
PR-URL: https://github.com/nodejs/node/pull/11287
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Diffstat (limited to 'benchmark/README.md')
| -rw-r--r-- | benchmark/README.md | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/benchmark/README.md b/benchmark/README.md index 8796e1e7b6..d123347075 100644 --- a/benchmark/README.md +++ b/benchmark/README.md @@ -22,7 +22,7 @@ either [`wrk`][wrk] or [`autocannon`][autocannon]. path, hence if you want to compare two HTTP benchmark runs make sure that the Node version in the path is not altered. -`wrk` may be available through your preferred package manger. If not, you can +`wrk` may be available through your preferred package manager. If not, you can easily build it [from source][wrk] via `make`. By default `wrk` will be used as benchmarker. If it is not available @@ -55,8 +55,8 @@ In the event you get a message that you need to select a CRAN mirror first. You can specify a mirror by adding in the repo parameter. -If we used the "http://cran.us.r-project.org" mirror, it could look somehting like -this: +If we used the "http://cran.us.r-project.org" mirror, it could look something +like this: ```R install.packages("ggplot2", repo="http://cran.us.r-project.org") @@ -180,7 +180,7 @@ to be no improvements, then there shouldn't be any stars. **A word of caution:** Statistics is not a foolproof tool. If a benchmark shows a statistical significant difference, there is a 5% risk that this -difference doesn't actually exists. For a single benchmark this is not an +difference doesn't actually exist. For a single benchmark this is not an issue. But when considering 20 benchmarks it's normal that one of them will show significance, when it shouldn't. A possible solution is to instead consider at least two stars (`**`) as the threshold, in that case the risk |