diff options
| author | Daniel Bevenius <daniel.bevenius@gmail.com> | 2018-10-04 07:49:06 +0200 |
|---|---|---|
| committer | Daniel Bevenius <daniel.bevenius@gmail.com> | 2018-10-05 07:18:30 +0200 |
| commit | ff3fd3bf8091c4525ab0e52dc18915d93fcd91b2 (patch) | |
| tree | 3b9459b4b84b722e3b5eb24a3fbcef648b39e6b8 /Makefile | |
| parent | c1cad2f9dfeb65da0d6300c462fd41f87baae1fd (diff) | |
| download | android-node-v8-ff3fd3bf8091c4525ab0e52dc18915d93fcd91b2.tar.gz android-node-v8-ff3fd3bf8091c4525ab0e52dc18915d93fcd91b2.tar.bz2 android-node-v8-ff3fd3bf8091c4525ab0e52dc18915d93fcd91b2.zip | |
build: toggle lint-cpp using verbose (V) variable
This commit the verbosity of cpplint to be toggled by using the V
variable. The default setting is verbose but by passing an empty string
cpplint will be quiet.
PR-URL: https://github.com/nodejs/node/pull/23217
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Diffstat (limited to 'Makefile')
| -rw-r--r-- | Makefile | 10 |
1 files changed, 8 insertions, 2 deletions
@@ -1181,19 +1181,25 @@ else @echo "To install (requires internet access) run: $ make format-cpp-build" endif +ifeq ($(V),1) + CPPLINT_QUIET = +else + CPPLINT_QUIET = --quiet +endif .PHONY: lint-cpp # Lints the C++ code with cpplint.py and check-imports.py. lint-cpp: tools/.cpplintstamp tools/.cpplintstamp: $(LINT_CPP_FILES) @echo "Running C++ linter..." - @$(PYTHON) tools/cpplint.py --quiet $? + @$(PYTHON) tools/cpplint.py $(CPPLINT_QUIET) $? @$(PYTHON) tools/check-imports.py @touch $@ lint-addon-docs: test/addons/.docbuildstamp @echo "Running C++ linter on addon docs..." - @$(PYTHON) tools/cpplint.py --quiet --filter=$(ADDON_DOC_LINT_FLAGS) $(LINT_CPP_ADDON_DOC_FILES_GLOB) + @$(PYTHON) tools/cpplint.py $(CPPLINT_QUIET) --filter=$(ADDON_DOC_LINT_FLAGS) \ + $(LINT_CPP_ADDON_DOC_FILES_GLOB) cpplint: lint-cpp @echo "Please use lint-cpp instead of cpplint" |