diff options
| author | Refael Ackermann <refack@gmail.com> | 2018-10-18 11:00:11 -0400 |
|---|---|---|
| committer | Refael Ackermann <refack@gmail.com> | 2018-10-20 11:02:50 -0400 |
| commit | b3ae9150de99a9b7b92ceddb11cd9e43ea92c7cb (patch) | |
| tree | 436603511a7bf3e15c867b49594ecd1a69270ca3 /Makefile | |
| parent | 87719d792b855e4278dbd3ca209592d83e80ac37 (diff) | |
| download | android-node-v8-b3ae9150de99a9b7b92ceddb11cd9e43ea92c7cb.tar.gz android-node-v8-b3ae9150de99a9b7b92ceddb11cd9e43ea92c7cb.tar.bz2 android-node-v8-b3ae9150de99a9b7b92ceddb11cd9e43ea92c7cb.zip | |
build: spawn `make test-ci` with `-j1`
All the sub targets have internal parallelism, so no performance loss.
Also `make` doesn't to a good enough job of combining the output
streams, or eliminate races.
PR-URL: https://github.com/nodejs/node/pull/23733
Fixes: https://github.com/nodejs/node/issues/22006
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Diffstat (limited to 'Makefile')
| -rw-r--r-- | Makefile | 5 |
1 files changed, 4 insertions, 1 deletions
@@ -480,8 +480,11 @@ build-ci: # of tests. See `test-ci-native` and `test-ci-js`. # - node-test-commit-linux-coverage: where the build and the tests need # to be instrumented, see `coverage`. +# +# Using -j1 as the sub target in `test-ci` already have internal parallelism. +# Refs: https://github.com/nodejs/node/pull/23733 run-ci: build-ci - $(MAKE) test-ci + $(MAKE) test-ci -j1 test-release: test-build $(PYTHON) tools/test.py $(PARALLEL_ARGS) --mode=$(BUILDTYPE_LOWER) |