diff options
| author | Rich Trott <rtrott@gmail.com> | 2019-04-05 11:26:37 -0700 |
|---|---|---|
| committer | Rich Trott <rtrott@gmail.com> | 2019-04-07 19:34:35 -0700 |
| commit | 557bd861aad28f737d7e83d4bfd035ad84c3d5be (patch) | |
| tree | c4f6cc98edf4d117bd79bf711c28ad18034e6fc3 /GOVERNANCE.md | |
| parent | 1afec971304e5c6294bbf61bddb39b55e76b4672 (diff) | |
| download | android-node-v8-557bd861aad28f737d7e83d4bfd035ad84c3d5be.tar.gz android-node-v8-557bd861aad28f737d7e83d4bfd035ad84c3d5be.tar.bz2 android-node-v8-557bd861aad28f737d7e83d4bfd035ad84c3d5be.zip | |
doc: revise Collaborator material in GOVERNANCE.md
* Reduce passive voice
* Shorter and simpler sentences
PR-URL: https://github.com/nodejs/node/pull/27103
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Diffstat (limited to 'GOVERNANCE.md')
| -rw-r--r-- | GOVERNANCE.md | 23 |
1 files changed, 9 insertions, 14 deletions
diff --git a/GOVERNANCE.md b/GOVERNANCE.md index 6e7a376442..d3374ec8c2 100644 --- a/GOVERNANCE.md +++ b/GOVERNANCE.md @@ -21,26 +21,21 @@ privileges include but are not limited to: * Commit access to the [nodejs/node][] repository * Access to the Node.js continuous integration (CI) jobs -Modifications of the contents of the nodejs/node repository are made on -a collaborative basis. Anybody with a GitHub account may propose a -modification via pull request and it will be considered by the project -Collaborators. +Both Collaborators and non-Collaborators may propose changes to the Node.js +source code. The mechanism to propose such a change is a GitHub pull request. +Collaborators are responsible for reviewing and merging (_landing_) +pull requests. At least two Collaborators must approve a pull request before the pull request -lands. (One Collaborator approval is enough if the pull request has been open +can land. (One Collaborator approval is enough if the pull request has been open for more than 7 days.) Approving a pull request indicates that the Collaborator accepts responsibility for the change. Approval must be from Collaborators who are not authors of the change. -If one or more Collaborators oppose a proposed change, then the change cannot -be accepted unless: - -* Discussions and/or additional changes result in no Collaborators objecting to - the change. Previously-objecting Collaborators do not necessarily have to - sign off on the change, but they should not be opposed to it. -* The change is escalated to the TSC and the TSC votes to approve the change. - This should only happen if disagreements between Collaborators cannot be - resolved through discussion. +If a Collaborator opposes a proposed change, then the change cannot land. The +exception is if the TSC votes to approve the change despite the opposition. +Usually, involving the TSC is unnecessary. Often, discussions or further changes +result in Collaborators removing their opposition. See: |