summaryrefslogtreecommitdiff
path: root/GOVERNANCE.md
diff options
context:
space:
mode:
authorRich Trott <rtrott@gmail.com>2019-11-04 19:51:48 -0800
committerRich Trott <rtrott@gmail.com>2019-11-06 20:05:57 -0800
commit35ae49db515ec4a7ad74ee3666eda34e7bfd85b5 (patch)
treef8f3e63498c181e0d57c0f1f304469dc8a3c358e /GOVERNANCE.md
parent115792dfde436354c82f38361cbff75ad226b8d0 (diff)
downloadandroid-node-v8-35ae49db515ec4a7ad74ee3666eda34e7bfd85b5.tar.gz
android-node-v8-35ae49db515ec4a7ad74ee3666eda34e7bfd85b5.tar.bz2
android-node-v8-35ae49db515ec4a7ad74ee3666eda34e7bfd85b5.zip
doc: update GOVERNANCE.md
This consists of some hopefully-uncontroversial simplifications/clarifications to the text. The one substantial change is to update Node.js Board of Directors to be the OpenJS Board of Directors. PR-URL: https://github.com/nodejs/node/pull/30259 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Michaƫl Zasso <targos@protonmail.com> Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Diffstat (limited to 'GOVERNANCE.md')
-rw-r--r--GOVERNANCE.md36
1 files changed, 16 insertions, 20 deletions
diff --git a/GOVERNANCE.md b/GOVERNANCE.md
index c856029116..d7cb6e321e 100644
--- a/GOVERNANCE.md
+++ b/GOVERNANCE.md
@@ -15,22 +15,21 @@
## Collaborators
Node.js Core Collaborators maintain the [nodejs/node][] GitHub repository.
-The GitHub team for Node.js Core Collaborators is @nodejs/collaborators. Their
-privileges include but are not limited to:
+The GitHub team for Node.js Core Collaborators is @nodejs/collaborators.
+Collaborators have:
* Commit access to the [nodejs/node][] repository
* Access to the Node.js continuous integration (CI) jobs
Both Collaborators and non-Collaborators may propose changes to the Node.js
source code. The mechanism to propose such a change is a GitHub pull request.
-Collaborators are responsible for reviewing and merging (_landing_)
-pull requests.
+Collaborators review and merge (_land_) pull requests.
-At least two Collaborators must approve a pull request before the pull request
-can land. (One Collaborator approval is enough if the pull request has been open
-for more than 7 days.) Approving a pull request indicates that the Collaborator
-accepts responsibility for the change. Approval must be from Collaborators who
-are not authors of the change.
+Two Collaborators must approve a pull request before the pull request can land.
+(One Collaborator approval is enough if the pull request has been open for more
+than 7 days.) Approving a pull request indicates that the Collaborator accepts
+responsibility for the change. Approval must be from Collaborators who are not
+authors of the change.
If a Collaborator opposes a proposed change, then the change cannot land. The
exception is if the TSC votes to approve the change despite the opposition.
@@ -39,13 +38,11 @@ result in Collaborators removing their opposition.
See:
-* [Current list of Collaborators](./README.md#current-project-team-members)
+* [List of Collaborators](./README.md#current-project-team-members)
* [A guide for Collaborators](./COLLABORATOR_GUIDE.md)
### Collaborator Activities
-Typical activities of a Collaborator include:
-
* Helping users and novice contributors
* Contributing code and documentation changes that improve the project
* Reviewing and commenting on issues and pull requests
@@ -71,7 +68,7 @@ The current list of TSC members is in
[the project README](./README.md#current-project-team-members).
The [TSC Charter][] governs the operations of the TSC. All changes to the
-Charter need approval by the Node.js Board of Directors.
+Charter need approval by the OpenJS Foundation Board of Directors.
### TSC Meetings
@@ -124,7 +121,7 @@ Provide a summary of the nominee's contributions. For example:
* Use the link `https://github.com/nodejs/node/issues?q=commenter:GITHUB_ID`
* Reviews on pull requests in the [nodejs/node][] repository
* Use the link `https://github.com/nodejs/node/pulls?q=reviewed-by:GITHUB_ID`
-* Help provided to end users and novice contributors
+* Help provided to end-users and novice contributors
* Pull requests and issues opened throughout the Node.js organization
* Use the link `https://github.com/search?q=author:GITHUB_ID+org:nodejs`
* Comments on pull requests and issues throughout the Node.js organization
@@ -144,16 +141,15 @@ frictionless as possible. Use the [Collaborators discussion page][] to request
feedback from other Collaborators in private. A nominator may also work with the
nominee to improve their contribution profile.
-It is possible that Collaborators will overlook someone with valuable
-contributions. In that case, the contributor may open an issue or contact a
-Collaborator to request a nomination.
+Collaborators might overlook someone with valuable contributions. In that case,
+the contributor may open an issue or contact a Collaborator to request a
+nomination.
### Onboarding
After the nomination passes, a TSC member onboards the new Collaborator. See
-[the onboarding guide](./doc/onboarding.md) on details of the onboarding
-process. In general, the onboarding should occur within a month after the
-nomination passes.
+[the onboarding guide](./doc/onboarding.md) for details of the onboarding
+process.
## Consensus Seeking Process