aboutsummaryrefslogtreecommitdiff
path: root/ChangeLog
diff options
context:
space:
mode:
authorTimothy J Fontaine <tjfontaine@gmail.com>2013-11-12 11:23:19 -0800
committerTimothy J Fontaine <tjfontaine@gmail.com>2013-11-12 11:23:19 -0800
commit16934d9210546bf19d4af8d98652aa5d636ce693 (patch)
tree1905f35f84db3ab6dc82bc6bff5dac2b835817aa /ChangeLog
parentac799ba0afa9731e281bf23886d1a3f5adec1784 (diff)
downloadandroid-node-v8-16934d9210546bf19d4af8d98652aa5d636ce693.tar.gz
android-node-v8-16934d9210546bf19d4af8d98652aa5d636ce693.tar.bz2
android-node-v8-16934d9210546bf19d4af8d98652aa5d636ce693.zip
src: add HandleScope in HandleWrap::OnClose
Fixes a 4 byte leak on handles closing. AKA The Walmart leak. MakeCallback doesn't have a HandleScope. That means the callers scope will retain ownership of created handles from MakeCallback and related. There is by default a wrapping HandleScope before uv_run, if the caller doesn't have a HandleScope on the stack the global will take ownership which won't be reaped until the uv loop exits. If a uv callback is fired, and there is no enclosing HandleScope in the cb, you will appear to leak 4-bytes for every invocation. Take heed. cc @hueniverse
Diffstat (limited to 'ChangeLog')
0 files changed, 0 insertions, 0 deletions