diff options
| author | Rich Trott <rtrott@gmail.com> | 2019-11-07 20:10:23 -0800 |
|---|---|---|
| committer | Rich Trott <rtrott@gmail.com> | 2019-11-10 07:55:48 -0800 |
| commit | e44d73f0117b9a1f7e5f9af759871b24638331a6 (patch) | |
| tree | a2a0cb0e5b8a72decfc6dddab8378aedbba1afcd /COLLABORATOR_GUIDE.md | |
| parent | 4b97c3addb246274cd7e8432edd537e0bdf60b63 (diff) | |
| download | android-node-v8-e44d73f0117b9a1f7e5f9af759871b24638331a6.tar.gz android-node-v8-e44d73f0117b9a1f7e5f9af759871b24638331a6.tar.bz2 android-node-v8-e44d73f0117b9a1f7e5f9af759871b24638331a6.zip | |
doc,meta: allow Travis results for doc/comment changes
Permit the use of Travis CI results for pull requests that only change
documentation or comments. This also removes
node-test-pull-request-lite-pipeline from the documentation. Efforts to
move all CI jobs to pipelines have stalled and it's not clear that our
current Jenkins admins are enthusiastic about pipelines.
PR-URL: https://github.com/nodejs/node/pull/30330
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Diffstat (limited to 'COLLABORATOR_GUIDE.md')
| -rw-r--r-- | COLLABORATOR_GUIDE.md | 9 |
1 files changed, 3 insertions, 6 deletions
diff --git a/COLLABORATOR_GUIDE.md b/COLLABORATOR_GUIDE.md index 0315a2dbb8..516a3d1f7b 100644 --- a/COLLABORATOR_GUIDE.md +++ b/COLLABORATOR_GUIDE.md @@ -172,8 +172,9 @@ the comment anyway to avoid any doubt. All fixes must have a test case which demonstrates the defect. The test should fail before the change, and pass after the change. -All pull requests must pass continuous integration tests on the -[project CI server](https://ci.nodejs.org/). +All pull requests must pass continuous integration tests. Code changes must pass +on [project CI server](https://ci.nodejs.org/). Pull requests that only change +documentation and comments can use Travis CI results. Do not land any pull requests without passing (green or yellow) CI runs. If there are CI failures unrelated to the change in the pull request, try "Resume @@ -187,10 +188,6 @@ everything else. is the CI job to test pull requests. It runs the `build-ci` and `test-ci` targets on all supported platforms. -* [`node-test-pull-request-lite-pipeline`](https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/) -runs the linter job. It also runs the tests on a very fast host. This is useful -for changes that only affect comments or documentation. - * [`citgm-smoker`](https://ci.nodejs.org/job/citgm-smoker/) uses [`CitGM`](https://github.com/nodejs/citgm) to allow you to run `npm install && npm test` on a large selection of common modules. This is |