diff options
| author | Rich Trott <rtrott@gmail.com> | 2019-02-04 20:08:47 -0800 |
|---|---|---|
| committer | Rich Trott <rtrott@gmail.com> | 2019-02-06 20:20:34 -0800 |
| commit | cf43846e25c67c9f36152d0643faf181df247527 (patch) | |
| tree | 73807dfadad319fe71489d91446235df1ac18b8b /COLLABORATOR_GUIDE.md | |
| parent | a046ae5ceddcaaf695df60be5dbc9d725beb6f22 (diff) | |
| download | android-node-v8-cf43846e25c67c9f36152d0643faf181df247527.tar.gz android-node-v8-cf43846e25c67c9f36152d0643faf181df247527.tar.bz2 android-node-v8-cf43846e25c67c9f36152d0643faf181df247527.zip | |
doc: revise Collaborator Guide on reverting
Revise the "Reverting commits" section of the Collaborator Guide. Reduce
passive voice. Increase clarity.
PR-URL: https://github.com/nodejs/node/pull/25942
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Diffstat (limited to 'COLLABORATOR_GUIDE.md')
| -rw-r--r-- | COLLABORATOR_GUIDE.md | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/COLLABORATOR_GUIDE.md b/COLLABORATOR_GUIDE.md index 232655e5dd..9bfc97147b 100644 --- a/COLLABORATOR_GUIDE.md +++ b/COLLABORATOR_GUIDE.md @@ -285,10 +285,10 @@ after-the-fact. ##### Reverting commits -Commits are reverted with `git revert <HASH>`, or `git revert <FROM>..<TO>` for -multiple commits. Commit metadata and the reason for the revert should be -appended. Commit message rules about line length and subsystem can be ignored. -A Pull Request should be raised and approved like any other change. +Revert commits with `git revert <HASH>` or `git revert <FROM>..<TO>`. The +generated commit message will not have a subsystem and may violate line length +rules. That is OK. Append the reason for the revert and any `Refs` or `Fixes` +metadata. Raise a Pull Request like any other change. ### Introducing New Modules |