diff options
| author | Rich Trott <rtrott@gmail.com> | 2018-04-29 20:26:29 -0700 |
|---|---|---|
| committer | Rich Trott <rtrott@gmail.com> | 2018-04-30 10:44:39 -0700 |
| commit | ca8055164028a84a84399f4aab59587dcfd24cd6 (patch) | |
| tree | f77cad4e7d87b0a140e4cc5daf83b3f023a0545a /COLLABORATOR_GUIDE.md | |
| parent | c6d3b37650e342e0b6eae8b74c9653ced5434db0 (diff) | |
| download | android-node-v8-ca8055164028a84a84399f4aab59587dcfd24cd6.tar.gz android-node-v8-ca8055164028a84a84399f4aab59587dcfd24cd6.tar.bz2 android-node-v8-ca8055164028a84a84399f4aab59587dcfd24cd6.zip | |
doc: remove "has been known" tentativeness
Remove unnecessary "has been known to" tentativeness from
COLLABORATOR_GUIDE.md. "has been known to" is an awkward replacement for
"can" or "might" or "sometimes does" or "does". Pick the right one and
use it.
PR-URL: https://github.com/nodejs/node/pull/20412
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Diffstat (limited to 'COLLABORATOR_GUIDE.md')
| -rw-r--r-- | COLLABORATOR_GUIDE.md | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/COLLABORATOR_GUIDE.md b/COLLABORATOR_GUIDE.md index a7b1e68d72..89c532e9d0 100644 --- a/COLLABORATOR_GUIDE.md +++ b/COLLABORATOR_GUIDE.md @@ -489,8 +489,7 @@ The TSC should serve as the final arbiter where required. 1. Never use GitHub's green ["Merge Pull Request"][] button. Reasons for not using the web interface button: * The merge method will add an unnecessary merge commit. - * The squash & merge method has been known to add metadata to the commit - title (the PR #). + * The squash & merge method can add metadata (the PR #) to the commit title. * If more than one author has contributed to the PR, keep the most recent author when squashing. 1. Make sure the CI is done and the result is green. If the CI is not green, |