diff options
| author | Franziska Hinkelmann <franzih@chromium.org> | 2018-09-07 19:46:30 -0400 |
|---|---|---|
| committer | Rich Trott <rtrott@gmail.com> | 2018-10-03 10:32:27 -0700 |
| commit | af522c1440ce491285b9c1f1f89f58c95f21b4d3 (patch) | |
| tree | accaca2dd28c8fc7af3ed999814311e49efaccc9 /COLLABORATOR_GUIDE.md | |
| parent | 1f780be7d180520ffe943c8ce65c797b84f82a01 (diff) | |
| download | android-node-v8-af522c1440ce491285b9c1f1f89f58c95f21b4d3.tar.gz android-node-v8-af522c1440ce491285b9c1f1f89f58c95f21b4d3.tar.bz2 android-node-v8-af522c1440ce491285b9c1f1f89f58c95f21b4d3.zip | |
doc: clarify assigning issues to the TSC
PR-URL: https://github.com/nodejs/node/pull/22759
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Diffstat (limited to 'COLLABORATOR_GUIDE.md')
| -rw-r--r-- | COLLABORATOR_GUIDE.md | 10 |
1 files changed, 7 insertions, 3 deletions
diff --git a/COLLABORATOR_GUIDE.md b/COLLABORATOR_GUIDE.md index 70f4b1a87c..513faa46c8 100644 --- a/COLLABORATOR_GUIDE.md +++ b/COLLABORATOR_GUIDE.md @@ -486,9 +486,8 @@ level. ### Involving the TSC -Collaborators may opt to elevate pull requests or issues to the [TSC][] for -discussion by assigning the `tsc-review` label or @-mentioning the -`@nodejs/tsc` GitHub team. This should be done where a pull request: +Collaborators may opt to elevate pull requests or issues to the [TSC][]. +This should be done where a pull request: - is labeled `semver-major`, or - has a significant impact on the codebase, or @@ -496,6 +495,11 @@ discussion by assigning the `tsc-review` label or @-mentioning the - has failed to reach consensus amongst the Collaborators who are actively participating in the discussion. +Assign the `tsc-review` label or @-mention the +`@nodejs/tsc` GitHub team if you want to elevate an issue to the [TSC][]. +Do not use the GitHub UI on the right hand side to assign to +`@nodejs/tsc` or request a review from `@nodejs/tsc`. + The TSC should serve as the final arbiter where required. ## Landing Pull Requests |