diff options
| author | Rich Trott <rtrott@gmail.com> | 2018-11-23 15:56:40 -0800 |
|---|---|---|
| committer | Rich Trott <rtrott@gmail.com> | 2018-11-25 16:52:59 -0800 |
| commit | 92986837ff0904af34b63f0849f9b5a05b76137c (patch) | |
| tree | ff060cb50f2b3edceebcb647c025c5b96b5db1b1 /COLLABORATOR_GUIDE.md | |
| parent | b507783bc116d6703f374d1d096b057df51191be (diff) | |
| download | android-node-v8-92986837ff0904af34b63f0849f9b5a05b76137c.tar.gz android-node-v8-92986837ff0904af34b63f0849f9b5a05b76137c.tar.bz2 android-node-v8-92986837ff0904af34b63f0849f9b5a05b76137c.zip | |
doc: revise handling-own-pull-requests text
Simplify and clarify the text of the COLLABORATORS_GUIDE where handling
one's own pull requests is concerned.
PR-URL: https://github.com/nodejs/node/pull/24583
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Diffstat (limited to 'COLLABORATOR_GUIDE.md')
| -rw-r--r-- | COLLABORATOR_GUIDE.md | 24 |
1 files changed, 11 insertions, 13 deletions
diff --git a/COLLABORATOR_GUIDE.md b/COLLABORATOR_GUIDE.md index 0be47023ea..90d52105a7 100644 --- a/COLLABORATOR_GUIDE.md +++ b/COLLABORATOR_GUIDE.md @@ -76,22 +76,20 @@ A pull request is _author ready_ when: pull request is older than 7 days. * There are no outstanding review comments. -Please always add the `author ready` label to the PR in that case. Please always -remove it again as soon as the conditions are not met anymore. +Please always add the `author ready` label to the pull request in that case. +Please always remove it again as soon as the conditions are not met anymore. ### Handling own pull requests -When you open a pull request, it is recommended to start a CI right away (see -[testing and CI](#testing-and-ci) for instructions) and to post the link to it -in a comment in the pull request. Starting a new CI after each update is also -recommended (for example, after an additional code change or after rebasing). - -As soon as the PR is ready to land, please do so. Landing your own pull requests -allows other Collaborators to focus on other pull requests. If your pull request -is still awaiting the [minimum time to land](#waiting-for-approvals), add the -`author ready` label so other Collaborators know it can land as soon as the time -ends. If instead you wish to land the PR yourself, indicate this intent by using -the "assign yourself" button, to self-assign the PR. +When you open a pull request, [start a CI](#testing-and-ci) right away and post +the link to it in a comment in the pull request. Later, after new code changes +or rebasing, start a new CI. + +As soon as the pull request is ready to land, please do so. This allows other +Collaborators to focus on other pull requests. If your pull request is not ready +to land but is [author ready](#author-ready-pull-requests), add the +`author ready` label. If you wish to land the pull request yourself, use the +"assign yourself" link to self-assign it. ## Accepting Modifications |