summaryrefslogtreecommitdiff
path: root/COLLABORATOR_GUIDE.md
diff options
context:
space:
mode:
authorAli Ijaz Sheikh <ofrobots@google.com>2015-10-25 17:19:58 -0700
committerAli Ijaz Sheikh <ofrobots@google.com>2015-10-28 08:20:31 -0700
commit81f6b543d94d43fee9dc313e47a22199dd1ed5ba (patch)
treed4d5491c83bc41b9c2d008020362e4914726bafd /COLLABORATOR_GUIDE.md
parentc9e682d587e3095667423cd7ada1afea7561ff3e (diff)
downloadandroid-node-v8-81f6b543d94d43fee9dc313e47a22199dd1ed5ba.tar.gz
android-node-v8-81f6b543d94d43fee9dc313e47a22199dd1ed5ba.tar.bz2
android-node-v8-81f6b543d94d43fee9dc313e47a22199dd1ed5ba.zip
deps: backport 010897c from V8 upstream
This is a reland of https://github.com/nodejs/node/pull/3165. The patch abates the truncation of script filenames in the perf-event output produced by V8. V8 commits: Original: https://github.com/v8/v8/commit/03ef3cd004c2fd31ae7e48772f106df67b8c2feb Reland: https://github.com/v8/v8/commit/010897c16adb46d3fe403eab525502a63e174b0c Original commit message: improve perf_basic_prof filename reporting The buffer used for appending filenames to the string printed to the perf_basic_prof log was unnecessarily too small. Bump it up to be at least kUtf8BufferSize. Truncation of filenames makes it really hard to work with profiles gathered on Node.js. Because of the way Node.js works, you can have node module dependencies in deeply nested directories. The last thing you want when investigating a performance problem is to have script names be truncated. This patch is a stop-gap. Ideally, I want no truncation of the filename at all and use a dynamically growing buffer. That would be a larger change, and I wanted to have a quick fix available that can be back-ported to Node.js LTS release. R=yangguo@chromium.org,yurys@chromium.org BUG= Review URL: https://codereview.chromium.org/1388543002 PR-URL: https://github.com/nodejs/node/pull/3520 Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
Diffstat (limited to 'COLLABORATOR_GUIDE.md')
0 files changed, 0 insertions, 0 deletions