diff options
| author | Rich Trott <rtrott@gmail.com> | 2019-06-15 19:30:55 -0700 |
|---|---|---|
| committer | Rich Trott <rtrott@gmail.com> | 2019-06-18 09:35:11 -0700 |
| commit | 8030ca5b9e593a5a800f40f09677a4eca31d1cd0 (patch) | |
| tree | 632298cb7397352f82690b8479bc6a7c0d620f7d /COLLABORATOR_GUIDE.md | |
| parent | 779a243f86f6a4c2a65392732574f3a53f96fd20 (diff) | |
| download | android-node-v8-8030ca5b9e593a5a800f40f09677a4eca31d1cd0.tar.gz android-node-v8-8030ca5b9e593a5a800f40f09677a4eca31d1cd0.tar.bz2 android-node-v8-8030ca5b9e593a5a800f40f09677a4eca31d1cd0.zip | |
doc: remove instructions to post CI links
Remove instructions (in the Collaborator Guide) to post CI links. The
bot does that now.
PR-URL: https://github.com/nodejs/node/pull/28248
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Diffstat (limited to 'COLLABORATOR_GUIDE.md')
| -rw-r--r-- | COLLABORATOR_GUIDE.md | 9 |
1 files changed, 4 insertions, 5 deletions
diff --git a/COLLABORATOR_GUIDE.md b/COLLABORATOR_GUIDE.md index 6e85bdc02e..93e6522e04 100644 --- a/COLLABORATOR_GUIDE.md +++ b/COLLABORATOR_GUIDE.md @@ -77,9 +77,8 @@ Please always remove it again as soon as the conditions are not met anymore. ### Handling own pull requests -When you open a pull request, [start a CI](#testing-and-ci) right away and post -the link to it in a comment in the pull request. Later, after new code changes -or rebasing, start a new CI. +When you open a pull request, [start a CI](#testing-and-ci) right away. Later, +after new code changes or rebasing, start a new CI. As soon as the pull request is ready to land, please do so. This allows other Collaborators to focus on other pull requests. If your pull request is not ready @@ -109,8 +108,8 @@ review by @-mention. See [Who to CC in the issue tracker](#who-to-cc-in-the-issue-tracker). If you are the first Collaborator to approve a pull request that has no CI yet, -please [start one](#testing-and-ci). Post the link to the CI in the PR. Please -also start a new CI if the PR creator pushed new code since the last CI run. +please [start one](#testing-and-ci). Please also start a new CI if the PR +creator pushed new code since the last CI run. ### Consensus Seeking |