diff options
| author | Rich Trott <rtrott@gmail.com> | 2018-11-25 20:04:53 -0800 |
|---|---|---|
| committer | Rich Trott <rtrott@gmail.com> | 2018-11-27 21:59:01 -0800 |
| commit | 7d18e922ab093c9c85b365dbc7fd01984316abc3 (patch) | |
| tree | 3b829dae104ab122e1c3a1b294d3b3f8a026bfcf /COLLABORATOR_GUIDE.md | |
| parent | ec396e42c6e421b31782f2a5fa1561fb5e61fba3 (diff) | |
| download | android-node-v8-7d18e922ab093c9c85b365dbc7fd01984316abc3.tar.gz android-node-v8-7d18e922ab093c9c85b365dbc7fd01984316abc3.tar.bz2 android-node-v8-7d18e922ab093c9c85b365dbc7fd01984316abc3.zip | |
doc: revise accepting-modifications in guide
Revise the "Accepting Modifications" section of the Collaborator Guide.
PR-URL: https://github.com/nodejs/node/pull/24650
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Diffstat (limited to 'COLLABORATOR_GUIDE.md')
| -rw-r--r-- | COLLABORATOR_GUIDE.md | 10 |
1 files changed, 4 insertions, 6 deletions
diff --git a/COLLABORATOR_GUIDE.md b/COLLABORATOR_GUIDE.md index 90d52105a7..8673713564 100644 --- a/COLLABORATOR_GUIDE.md +++ b/COLLABORATOR_GUIDE.md @@ -93,12 +93,10 @@ to land but is [author ready](#author-ready-pull-requests), add the ## Accepting Modifications -All modifications to the Node.js code and documentation should be performed via -GitHub pull requests, including modifications by Collaborators and TSC members. -A pull request must be reviewed, and must also be tested with CI, before being -landed into the codebase. There may be exceptions to the latter (the changed -code cannot be tested with a CI or similar). If that is the case, please leave a -comment that explains why the PR does not require a CI run. +Contributors propose modifications to Node.js using GitHub pull requests. This +is true for all modifications including those proposed by TSC members and other +Collaborators. A pull request must pass code review and CI before landing into +the codebase. ### Code Reviews |