diff options
| author | Vse Mozhet Byt <vsemozhetbyt@gmail.com> | 2018-04-21 17:07:28 +0300 |
|---|---|---|
| committer | Vse Mozhet Byt <vsemozhetbyt@gmail.com> | 2018-04-22 03:07:53 +0300 |
| commit | 5389c9239252b89ad2b9a52759c65800a5813baf (patch) | |
| tree | 8679c1c1f8d3ffefb41ab7adc341b76187023be2 /COLLABORATOR_GUIDE.md | |
| parent | 31cbec7f55b63b86877da4599a7561f626b7c908 (diff) | |
| download | android-node-v8-5389c9239252b89ad2b9a52759c65800a5813baf.tar.gz android-node-v8-5389c9239252b89ad2b9a52759c65800a5813baf.tar.bz2 android-node-v8-5389c9239252b89ad2b9a52759c65800a5813baf.zip | |
doc: detail CI sub-tasks rerunning
PR-URL: https://github.com/nodejs/node/pull/20200
Fixes: https://github.com/nodejs/node/issues/20192
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Diffstat (limited to 'COLLABORATOR_GUIDE.md')
| -rw-r--r-- | COLLABORATOR_GUIDE.md | 13 |
1 files changed, 8 insertions, 5 deletions
diff --git a/COLLABORATOR_GUIDE.md b/COLLABORATOR_GUIDE.md index aac77f07f4..a7b1e68d72 100644 --- a/COLLABORATOR_GUIDE.md +++ b/COLLABORATOR_GUIDE.md @@ -199,11 +199,14 @@ status indicator. Do not land any Pull Requests without passing (green or yellow) CI runs. If you believe any failed (red or grey) CI sub-tasks are unrelated to the change in the -Pull Request, you may re-run the sub-task to try to see if it passes. If re-runs -of all failed sub-tasks pass, it is permissible to land the Pull Request but -only if the initial failures are believed in good faith to be unrelated to the -changes in the Pull Request. Otherwise, reasonable steps must be taken to -confirm that the changes are not resulting in an unreliable test. +Pull Request, you may re-run the sub-task to try to see if it passes (just open +the failed sub-task page and press the "Rebuild" button; be sure you are still +logged in for this action). If re-runs of all failed sub-tasks pass (do not +forget to provide the links for successfully rerun sub-tasks), it is permissible +to land the Pull Request but only if the initial failures are believed in good +faith to be unrelated to the changes in the Pull Request. Otherwise, reasonable +steps must be taken to confirm that the changes are not resulting in an +unreliable test. #### Useful CI Jobs |