diff options
| author | Ruben Bridgewater <ruben@bridgewater.de> | 2018-12-07 14:58:09 +0100 |
|---|---|---|
| committer | Rich Trott <rtrott@gmail.com> | 2018-12-09 20:03:27 -0800 |
| commit | 4aabd7ed641db5d78fdf7e1c93b93027ffc3a9b4 (patch) | |
| tree | cef16368022fe8f5cdb09168babb9791cb9985d5 /COLLABORATOR_GUIDE.md | |
| parent | 5652cb0b530078bc5c5b55369aefe5d4e627ecd3 (diff) | |
| download | android-node-v8-4aabd7ed641db5d78fdf7e1c93b93027ffc3a9b4.tar.gz android-node-v8-4aabd7ed641db5d78fdf7e1c93b93027ffc3a9b4.tar.bz2 android-node-v8-4aabd7ed641db5d78fdf7e1c93b93027ffc3a9b4.zip | |
doc: simplify author ready
The label should be applied early on. Otherwise there is little
benefit using this label at all.
PR-URL: https://github.com/nodejs/node/pull/24893
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Diffstat (limited to 'COLLABORATOR_GUIDE.md')
| -rw-r--r-- | COLLABORATOR_GUIDE.md | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/COLLABORATOR_GUIDE.md b/COLLABORATOR_GUIDE.md index 2bce29e564..de776bbaaa 100644 --- a/COLLABORATOR_GUIDE.md +++ b/COLLABORATOR_GUIDE.md @@ -72,8 +72,7 @@ issues and pull requests can always be re-opened if necessary. A pull request is _author ready_ when: * There is a CI run in progress or completed. -* There are at least two Collaborator approvals, or at least one approval if the - pull request is older than 7 days. +* There is at least one Collaborator approval. * There are no outstanding review comments. Please always add the `author ready` label to the pull request in that case. |