diff options
| author | Rich Trott <rtrott@gmail.com> | 2017-12-06 06:11:29 -0800 |
|---|---|---|
| committer | Rich Trott <rtrott@gmail.com> | 2017-12-08 13:27:53 -0800 |
| commit | 3ad01e749fffc0281d3639b1fdca65ee3619d90c (patch) | |
| tree | 39f88ae9f57ed74e8562ee22b3d35c67eb693ab0 /COLLABORATOR_GUIDE.md | |
| parent | 146a9b1a8a38285b0613559aa96498bc7859fc75 (diff) | |
| download | android-node-v8-3ad01e749fffc0281d3639b1fdca65ee3619d90c.tar.gz android-node-v8-3ad01e749fffc0281d3639b1fdca65ee3619d90c.tar.bz2 android-node-v8-3ad01e749fffc0281d3639b1fdca65ee3619d90c.zip | |
doc: use correct and consistent typography for products
Use `GitHub` rather than `Github` and `Node.js` rather than `Node.JS`.
PR-URL: https://github.com/nodejs/node/pull/17492
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Diffstat (limited to 'COLLABORATOR_GUIDE.md')
| -rw-r--r-- | COLLABORATOR_GUIDE.md | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/COLLABORATOR_GUIDE.md b/COLLABORATOR_GUIDE.md index 9a4b5184b3..358fd59476 100644 --- a/COLLABORATOR_GUIDE.md +++ b/COLLABORATOR_GUIDE.md @@ -89,7 +89,7 @@ change. In the case of pull requests proposed by an existing Collaborator, an additional Collaborator is required for sign-off. In some cases, it may be necessary to summon a qualified Collaborator -or a Github team to a pull request for review by @-mention. +or a GitHub team to a pull request for review by @-mention. [See "Who to CC in issues"](./doc/onboarding-extras.md#who-to-cc-in-issues) If you are unsure about the modification and are not prepared to take @@ -160,7 +160,7 @@ trivial changes that do not require being tested on all platforms. * [`citgm-smoker`](https://ci.nodejs.org/job/citgm-smoker/) uses [`CitGM`](https://github.com/nodejs/citgm) to allow you to run `npm install && npm test` on a large selection of common modules. This is useful to check whether a -change will cause breakage in the ecosystem. To test Node.JS ABI changes +change will cause breakage in the ecosystem. To test Node.js ABI changes you can run [`citgm-abi-smoker`](https://ci.nodejs.org/job/citgm-abi-smoker/). * [`node-stress-single-test`](https://ci.nodejs.org/job/node-stress-single-test/) @@ -408,7 +408,7 @@ Changes" section of the release notes. Collaborators may opt to elevate pull requests or issues to the [TSC][] for discussion by assigning the `tsc-review` label or @-mentioning the -`@nodejs/tsc` Github team. This should be done where a pull request: +`@nodejs/tsc` GitHub team. This should be done where a pull request: - is labeled `semver-major`, or - has a significant impact on the codebase, or |