diff options
| author | Rich Trott <rtrott@gmail.com> | 2019-03-10 21:27:29 -0700 |
|---|---|---|
| committer | Rich Trott <rtrott@gmail.com> | 2019-03-11 13:42:04 -0700 |
| commit | 2e2670a2073c89d700ab274a47bb0e6036046e65 (patch) | |
| tree | 8b205f6ce7491aa31a7946835b54eafed2c6bd86 /COLLABORATOR_GUIDE.md | |
| parent | 8f93c08346e416734d9e822c6a8c505c6c108eea (diff) | |
| download | android-node-v8-2e2670a2073c89d700ab274a47bb0e6036046e65.tar.gz android-node-v8-2e2670a2073c89d700ab274a47bb0e6036046e65.tar.bz2 android-node-v8-2e2670a2073c89d700ab274a47bb0e6036046e65.zip | |
doc: edit "Using git-node" section of Guide
Edit the "Using git-node" section of the Collaborator Guide. Make
sentences concise and clear, reduce use of passive voice, etc.
PR-URL: https://github.com/nodejs/node/pull/26580
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Diffstat (limited to 'COLLABORATOR_GUIDE.md')
| -rw-r--r-- | COLLABORATOR_GUIDE.md | 16 |
1 files changed, 7 insertions, 9 deletions
diff --git a/COLLABORATOR_GUIDE.md b/COLLABORATOR_GUIDE.md index 02a83ef736..48f6cfee29 100644 --- a/COLLABORATOR_GUIDE.md +++ b/COLLABORATOR_GUIDE.md @@ -419,9 +419,8 @@ tests. This makes it much easier when bisecting to find a breaking change. ### Using `git-node` In most cases, using [the `git-node` command][git-node] of [`node-core-utils`][] -should be enough to help you land a Pull Request. If you discover a problem when -using this tool, please file an issue -[to the issue tracker][node-core-utils-issues]. +should be enough to land a pull request. If you discover a problem when using +this tool, please file an issue [to the issue tracker][node-core-utils-issues]. Quick example: @@ -430,12 +429,11 @@ $ npm install -g node-core-utils $ git node land $PRID ``` -If it's the first time you have used `node-core-utils`, you will be prompted -to type the password of your GitHub account and the two-factor authentication -code in the console so the tool can create the GitHub access token for you. -If you do not want to do that, follow -[the `node-core-utils` guide][node-core-utils-credentials] -to set up your credentials manually. +To use `node-core-utils`, you will need a GitHub access token. If you do not +have one, `node-core-utils` will create one for you the first time you use it. +To do this, it will ask for your GitHub password and two-factor authentication +code. If you wish to create the token yourself in advance, see +[the `node-core-utils` guide][node-core-utils-credentials]. ### Technical HOWTO |