summaryrefslogtreecommitdiff
path: root/CHANGELOG.md
diff options
context:
space:
mode:
authorAnna Henningsen <anna@addaleax.net>2017-12-02 16:28:35 +0100
committerAnna Henningsen <anna@addaleax.net>2017-12-05 12:35:10 +0100
commit69a68c0b24b68a9f2d3e64fb0f968772f113f813 (patch)
treeb74eed7dc24f39d83a35d7a5409b6d3c122dde3b /CHANGELOG.md
parentb31626ef986f42d9113200a69940668c79b0f03e (diff)
downloadandroid-node-v8-69a68c0b24b68a9f2d3e64fb0f968772f113f813.tar.gz
android-node-v8-69a68c0b24b68a9f2d3e64fb0f968772f113f813.tar.bz2
android-node-v8-69a68c0b24b68a9f2d3e64fb0f968772f113f813.zip
buffer: zero-fill buffer allocated with invalid content
Zero-fill when `Buffer.alloc()` receives invalid fill data. A solution like https://github.com/nodejs/node/pull/17427 which switches to throwing makes sense, but is likely a breaking change. This suggestion leaves the behaviour of `buffer.fill()` untouched, since any change to it would be a breaking change, and lets `Buffer.alloc()` check whether any filling took place or not. PR-URL: https://github.com/nodejs/node/pull/17428 Refs: https://github.com/nodejs/node/pull/17427 Refs: https://github.com/nodejs/node/issues/17423 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Diffstat (limited to 'CHANGELOG.md')
0 files changed, 0 insertions, 0 deletions