diff options
| author | Rich Trott <rtrott@gmail.com> | 2018-09-27 15:45:08 -0700 |
|---|---|---|
| committer | Rich Trott <rtrott@gmail.com> | 2018-09-28 15:45:18 -0700 |
| commit | ea232bd320c4b15c1d07b2d3bafb565725f1e8f0 (patch) | |
| tree | 5640f20a9f4b4e0a56222b50eeec92ab09fc0018 /BUILDING.md | |
| parent | 27f3d9a64976ac4a7a726dde024ca9e2ea9cef7a (diff) | |
| download | android-node-v8-ea232bd320c4b15c1d07b2d3bafb565725f1e8f0.tar.gz android-node-v8-ea232bd320c4b15c1d07b2d3bafb565725f1e8f0.tar.bz2 android-node-v8-ea232bd320c4b15c1d07b2d3bafb565725f1e8f0.zip | |
test: fix flaky test-gc-net-timeout
There's a global.gc() invoked in an interval, and a second one in a
req.setTimeout() callback. Remove the one in the callback. I'm not sure
how competing global.gc() calls might result in a deadlock, but it seems
plausible and empirical testing confirms that it makes the test
reliable.
Fixes: https://github.com/nodejs/node/issues/23067
PR-URL: https://github.com/nodejs/node/pull/23139
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Diffstat (limited to 'BUILDING.md')
0 files changed, 0 insertions, 0 deletions