diff options
| author | Michaël Zasso <targos@protonmail.com> | 2019-10-18 11:04:35 +0200 |
|---|---|---|
| committer | Michaël Zasso <targos@protonmail.com> | 2019-10-20 16:08:15 +0200 |
| commit | b554214249b4d03ca68f98f2a2715511a7049397 (patch) | |
| tree | 89ab2b46d33abc78208f4eee2ffe8557857274aa /BUILDING.md | |
| parent | a4e075f66833d08fc426c9406eb3894ec56326c1 (diff) | |
| download | android-node-v8-b554214249b4d03ca68f98f2a2715511a7049397.tar.gz android-node-v8-b554214249b4d03ca68f98f2a2715511a7049397.tar.bz2 android-node-v8-b554214249b4d03ca68f98f2a2715511a7049397.zip | |
build: default Windows build to Visual Studio 2019
Building and testing Node.js with Visual Studio 2019 is now working as
expected.
Fallback to VS 2017 if VS 2019 was not found.
Fixes: https://github.com/nodejs/node/issues/27214
PR-URL: https://github.com/nodejs/node/pull/30022
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Diffstat (limited to 'BUILDING.md')
| -rw-r--r-- | BUILDING.md | 9 |
1 files changed, 5 insertions, 4 deletions
diff --git a/BUILDING.md b/BUILDING.md index aadba46020..006c21521d 100644 --- a/BUILDING.md +++ b/BUILDING.md @@ -498,9 +498,9 @@ $ backtrace * [Python 2.7](https://www.python.org/downloads/) * The "Desktop development with C++" workload from - [Visual Studio 2017](https://www.visualstudio.com/downloads/) or the - "Visual C++ build tools" workload from the - [Build Tools](https://www.visualstudio.com/downloads/#build-tools-for-visual-studio-2017), + [Visual Studio 2017 or 2019](https://visualstudio.microsoft.com/downloads/) or + the "Visual C++ build tools" workload from the + [Build Tools](https://visualstudio.microsoft.com/downloads/#build-tools-for-visual-studio-2019), with the default optional components. * Basic Unix tools required for some tests, [Git for Windows](https://git-scm.com/download/win) includes Git Bash @@ -513,7 +513,8 @@ $ backtrace Optional requirements to build the MSI installer package: * The [WiX Toolset v3.11](https://wixtoolset.org/releases/) and the - [Wix Toolset Visual Studio 2017 Extension](https://marketplace.visualstudio.com/items?itemName=RobMensching.WixToolsetVisualStudio2017Extension). + [Wix Toolset Visual Studio 2017 Extension](https://marketplace.visualstudio.com/items?itemName=RobMensching.WixToolsetVisualStudio2017Extension) + or the [Wix Toolset Visual Studio 2019 Extension](https://marketplace.visualstudio.com/items?itemName=WixToolset.WixToolsetVisualStudio2019Extension). Optional requirements for compiling for Windows 10 on ARM (ARM64): |