diff options
author | João Reis <reis@janeasystems.com> | 2019-09-03 16:44:50 +0100 |
---|---|---|
committer | Rich Trott <rtrott@gmail.com> | 2019-09-05 19:14:29 -0700 |
commit | 7bff96204bd2c4de4f7ff294d8d6be5a9c53c8d4 (patch) | |
tree | d835f7ad99f1455793acd20979dfed869ee49457 /BUILDING.md | |
parent | 2882ce911df821895c70d2ee99a88a4554fa3221 (diff) | |
download | android-node-v8-7bff96204bd2c4de4f7ff294d8d6be5a9c53c8d4.tar.gz android-node-v8-7bff96204bd2c4de4f7ff294d8d6be5a9c53c8d4.tar.bz2 android-node-v8-7bff96204bd2c4de4f7ff294d8d6be5a9c53c8d4.zip |
build,win: fix Python detection on localized OS
This code previously assumed the default value was always printed to
the console by reg.exe as "(default)", but this is not true on
localized versions of Windows and can contain spaces.
Fixes: https://github.com/nodejs/node/issues/29417
PR-URL: https://github.com/nodejs/node/pull/29423
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Diffstat (limited to 'BUILDING.md')
0 files changed, 0 insertions, 0 deletions