diff options
| author | Daniel Bevenius <daniel.bevenius@gmail.com> | 2018-05-10 19:24:16 +0200 |
|---|---|---|
| committer | Anna Henningsen <anna@addaleax.net> | 2018-05-10 23:37:44 +0200 |
| commit | 778f248914e1b498cd5d5e29006e346c62e8dcc6 (patch) | |
| tree | 4a2a60c144421f6568040305671c24bddf71a9e5 /BUILDING.md | |
| parent | f1cdd7749f873409e3929e2bc5d6a5bc3260796f (diff) | |
| download | android-node-v8-778f248914e1b498cd5d5e29006e346c62e8dcc6.tar.gz android-node-v8-778f248914e1b498cd5d5e29006e346c62e8dcc6.tar.bz2 android-node-v8-778f248914e1b498cd5d5e29006e346c62e8dcc6.zip | |
src: add missing override to ThreadPoolWork funcs
Currently the following warnings are displayed when compiling:
../src/node_api.cc:3380:8:
warning: 'AfterThreadPoolWork' overrides a member function but is not
marked 'override' [-Winconsistent-missing-override]
void AfterThreadPoolWork(int status) {
^
../src/node_internals.h:513:16: note: overridden virtual function is
here
virtual void AfterThreadPoolWork(int status) = 0;
^
1 warning generated.
../src/node_zlib.cc:220:8:
warning: 'DoThreadPoolWork' overrides a member function but is not
marked 'override' [-Winconsistent-missing-override]
void DoThreadPoolWork() {
^
../src/node_internals.h:512:16: note: overridden virtual function is
here
virtual void DoThreadPoolWork() = 0;
^
../src/node_zlib.cc:224:8:
warning: 'AfterThreadPoolWork' overrides a member function but is
not marked 'override' [-Winconsistent-missing-override]
void AfterThreadPoolWork(int status) {
^
../src/node_internals.h:513:16: note: overridden virtual function is
here
virtual void AfterThreadPoolWork(int status) = 0;
^
2 warnings generated.
This commit adds override to the functions.
PR-URL: https://github.com/nodejs/node/pull/20663
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Diffstat (limited to 'BUILDING.md')
0 files changed, 0 insertions, 0 deletions