diff options
author | cjihrig <cjihrig@gmail.com> | 2019-10-14 11:39:27 -0400 |
---|---|---|
committer | Rich Trott <rtrott@gmail.com> | 2019-10-15 22:19:16 -0700 |
commit | ff5a1cf5a8d61fd16d5190e7117e97e49d7edcb2 (patch) | |
tree | a4afe99f98294a0d521f692ee148459ccb67d174 | |
parent | d247a8e1dc398b76558b7eb8cceace911047e912 (diff) | |
download | android-node-v8-ff5a1cf5a8d61fd16d5190e7117e97e49d7edcb2.tar.gz android-node-v8-ff5a1cf5a8d61fd16d5190e7117e97e49d7edcb2.tar.bz2 android-node-v8-ff5a1cf5a8d61fd16d5190e7117e97e49d7edcb2.zip |
doc: add missing deprecation code
Refs: https://github.com/nodejs/node/pull/29061
PR-URL: https://github.com/nodejs/node/pull/29969
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
-rw-r--r-- | doc/api/deprecations.md | 4 | ||||
-rw-r--r-- | lib/internal/fs/streams.js | 4 | ||||
-rw-r--r-- | test/parallel/test-fs-read-stream-patch-open.js | 2 | ||||
-rw-r--r-- | test/parallel/test-fs-write-stream-patch-open.js | 2 |
4 files changed, 6 insertions, 6 deletions
diff --git a/doc/api/deprecations.md b/doc/api/deprecations.md index 8b36e0c3aa..e4c53d57c7 100644 --- a/doc/api/deprecations.md +++ b/doc/api/deprecations.md @@ -2532,8 +2532,8 @@ Type: Documentation-only (supports [`--pending-deprecation`][]) The `process._tickCallback` property was never documented as an officially supported API. -<a id="DEP0XXX"></a> -### DEP0XXX: `WriteStream.open()` and `ReadStream.open()` are internal +<a id="DEP0135"></a> +### DEP0135: `WriteStream.open()` and `ReadStream.open()` are internal <!-- YAML changes: - version: REPLACEME diff --git a/lib/internal/fs/streams.js b/lib/internal/fs/streams.js index 673dab34fb..0d292c8a53 100644 --- a/lib/internal/fs/streams.js +++ b/lib/internal/fs/streams.js @@ -114,7 +114,7 @@ Object.setPrototypeOf(ReadStream, Readable); const openReadFs = internalUtil.deprecate(function() { _openReadFs(this); -}, 'ReadStream.prototype.open() is deprecated', 'DEP0XXX'); +}, 'ReadStream.prototype.open() is deprecated', 'DEP0135'); ReadStream.prototype.open = openReadFs; function _openReadFs(stream) { @@ -299,7 +299,7 @@ WriteStream.prototype._final = function(callback) { const openWriteFs = internalUtil.deprecate(function() { _openWriteFs(this); -}, 'WriteStream.prototype.open() is deprecated', 'DEP0XXX'); +}, 'WriteStream.prototype.open() is deprecated', 'DEP0135'); WriteStream.prototype.open = openWriteFs; function _openWriteFs(stream) { diff --git a/test/parallel/test-fs-read-stream-patch-open.js b/test/parallel/test-fs-read-stream-patch-open.js index 80f8888de3..c658105132 100644 --- a/test/parallel/test-fs-read-stream-patch-open.js +++ b/test/parallel/test-fs-read-stream-patch-open.js @@ -4,7 +4,7 @@ const fs = require('fs'); common.expectWarning( 'DeprecationWarning', - 'ReadStream.prototype.open() is deprecated', 'DEP0XXX'); + 'ReadStream.prototype.open() is deprecated', 'DEP0135'); const s = fs.createReadStream('asd') // We don't care about errors in this test. .on('error', () => {}); diff --git a/test/parallel/test-fs-write-stream-patch-open.js b/test/parallel/test-fs-write-stream-patch-open.js index 1c82e80213..ac683785cb 100644 --- a/test/parallel/test-fs-write-stream-patch-open.js +++ b/test/parallel/test-fs-write-stream-patch-open.js @@ -25,7 +25,7 @@ if (process.argv[2] !== 'child') { common.expectWarning( 'DeprecationWarning', - 'WriteStream.prototype.open() is deprecated', 'DEP0XXX'); + 'WriteStream.prototype.open() is deprecated', 'DEP0135'); const s = fs.createWriteStream(`${tmpdir.path}/out`); s.open(); |