diff options
author | melinamejia95 <melinamejia95@gmail.com> | 2019-06-21 16:20:39 -0500 |
---|---|---|
committer | ZYSzys <zyszys98@gmail.com> | 2019-06-26 16:34:23 +0800 |
commit | fad3b643500dda23dbd630ef79dc8e9bd263599d (patch) | |
tree | 3bad2eef71d7124a3bc65b3175bb0371895c86a3 | |
parent | 945134361fb448a577a5c030e5fca1c69643399f (diff) | |
download | android-node-v8-fad3b643500dda23dbd630ef79dc8e9bd263599d.tar.gz android-node-v8-fad3b643500dda23dbd630ef79dc8e9bd263599d.tar.bz2 android-node-v8-fad3b643500dda23dbd630ef79dc8e9bd263599d.zip |
test: fixing broken test
test didn't throw the error, it was just returning it. So I removed
the try/catch and assigned the error to a variable
PR-URL: https://github.com/nodejs/node/pull/28345
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michaƫl Zasso <targos@protonmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
-rw-r--r-- | test/parallel/test-readable-from.js | 22 |
1 files changed, 10 insertions, 12 deletions
diff --git a/test/parallel/test-readable-from.js b/test/parallel/test-readable-from.js index a441f743cc..e43cec6b1e 100644 --- a/test/parallel/test-readable-from.js +++ b/test/parallel/test-readable-from.js @@ -6,7 +6,7 @@ const { Readable } = require('stream'); const { strictEqual } = require('assert'); async function toReadableBasicSupport() { - async function * generate() { + async function* generate() { yield 'a'; yield 'b'; yield 'c'; @@ -22,7 +22,7 @@ async function toReadableBasicSupport() { } async function toReadableSyncIterator() { - function * generate() { + function* generate() { yield 'a'; yield 'b'; yield 'c'; @@ -64,7 +64,7 @@ async function toReadableString() { } async function toReadableOnData() { - async function * generate() { + async function* generate() { yield 'a'; yield 'b'; yield 'c'; @@ -86,7 +86,7 @@ async function toReadableOnData() { } async function toReadableOnDataNonObject() { - async function * generate() { + async function* generate() { yield 'a'; yield 'b'; yield 'c'; @@ -109,7 +109,7 @@ async function toReadableOnDataNonObject() { } async function destroysTheStreamWhenThrowing() { - async function * generate() { + async function* generate() { throw new Error('kaboom'); } @@ -117,16 +117,14 @@ async function destroysTheStreamWhenThrowing() { stream.read(); - try { - await once(stream, 'error'); - } catch (err) { - strictEqual(err.message, 'kaboom'); - strictEqual(stream.destroyed, true); - } + const [err] = await once(stream, 'error'); + strictEqual(err.message, 'kaboom'); + strictEqual(stream.destroyed, true); + } async function asTransformStream() { - async function * generate(stream) { + async function* generate(stream) { for await (const chunk of stream) { yield chunk.toUpperCase(); } |