summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorNick Schonning <nschonni@gmail.com>2019-09-07 22:44:35 -0400
committerRich Trott <rtrott@gmail.com>2019-09-10 01:18:35 -0700
commitf6152857f94e9fbae1f3780f619434d44b60d0bc (patch)
treebc72d5f87651fcace7898fd4165b810dc89a2e18
parentc929b15d1d65ae88261c65e901c7dca9f110a2c5 (diff)
downloadandroid-node-v8-f6152857f94e9fbae1f3780f619434d44b60d0bc.tar.gz
android-node-v8-f6152857f94e9fbae1f3780f619434d44b60d0bc.tar.bz2
android-node-v8-f6152857f94e9fbae1f3780f619434d44b60d0bc.zip
doc: indent child list items for remark-lint
Child items not aligned to parent are flagged by list-item-bullet-indent PR-URL: https://github.com/nodejs/node/pull/29488 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
-rw-r--r--doc/api/modules.md2
-rw-r--r--doc/api/n-api.md6
-rw-r--r--doc/changelogs/CHANGELOG_ARCHIVE.md1
-rw-r--r--doc/changelogs/CHANGELOG_V5.md2
-rw-r--r--doc/changelogs/CHANGELOG_V7.md18
-rw-r--r--doc/guides/contributing/pull-requests.md4
6 files changed, 17 insertions, 16 deletions
diff --git a/doc/api/modules.md b/doc/api/modules.md
index b6afe80a0d..bffea8db7e 100644
--- a/doc/api/modules.md
+++ b/doc/api/modules.md
@@ -495,7 +495,7 @@ By doing this, Node.js achieves a few things:
- It keeps top-level variables (defined with `var`, `const` or `let`) scoped to
the module rather than the global object.
- It helps to provide some global-looking variables that are actually specific
-to the module, such as:
+ to the module, such as:
- The `module` and `exports` objects that the implementor can use to export
values from the module.
- The convenience variables `__filename` and `__dirname`, containing the
diff --git a/doc/api/n-api.md b/doc/api/n-api.md
index ae0bed2af3..8f4eac2957 100644
--- a/doc/api/n-api.md
+++ b/doc/api/n-api.md
@@ -3983,13 +3983,13 @@ Returns `napi_ok` if the API succeeded.
N-API offers a way to "wrap" C++ classes and instances so that the class
constructor and methods can be called from JavaScript.
- 1. The [`napi_define_class`][] API defines a JavaScript class with constructor,
+1. The [`napi_define_class`][] API defines a JavaScript class with constructor,
static properties and methods, and instance properties and methods that
correspond to the C++ class.
- 2. When JavaScript code invokes the constructor, the constructor callback
+2. When JavaScript code invokes the constructor, the constructor callback
uses [`napi_wrap`][] to wrap a new C++ instance in a JavaScript object,
then returns the wrapper object.
- 3. When JavaScript code invokes a method or property accessor on the class,
+3. When JavaScript code invokes a method or property accessor on the class,
the corresponding `napi_callback` C++ function is invoked. For an instance
callback, [`napi_unwrap`][] obtains the C++ instance that is the target of
the call.
diff --git a/doc/changelogs/CHANGELOG_ARCHIVE.md b/doc/changelogs/CHANGELOG_ARCHIVE.md
index 7ac84ca05d..f403042ff8 100644
--- a/doc/changelogs/CHANGELOG_ARCHIVE.md
+++ b/doc/changelogs/CHANGELOG_ARCHIVE.md
@@ -3438,6 +3438,7 @@ https://github.com/nodejs/node/commit/726865af7bbafe58435986f4a193ff11c84e4bfe
- Move node.dns into module "dns"
- Move node.fs into module "posix"
- process is no longer the global object. GLOBAL is.
+
For more information on the API changes see:
http://thread.gmane.org/gmane.comp.lang.javascript.nodejs/6
http://thread.gmane.org/gmane.comp.lang.javascript.nodejs/14
diff --git a/doc/changelogs/CHANGELOG_V5.md b/doc/changelogs/CHANGELOG_V5.md
index 72ad119c11..35b3d21f75 100644
--- a/doc/changelogs/CHANGELOG_V5.md
+++ b/doc/changelogs/CHANGELOG_V5.md
@@ -421,7 +421,7 @@ https://github.com/nodejs/node/pull/5655
* **v8**: backport fb4ccae from v8 upstream (Vladimir Krivosheev) #4231
- breakout events from v8 to offer better support for external debuggers
* **zlib**: add support for concatenated members (Kári Tristan Helgason)
-https://github.com/nodejs/node/pull/5120
+ https://github.com/nodejs/node/pull/5120
* Previously, if multiple members were in the same archive, only the first would be read. The others are no longer thrown away.
### Commits
diff --git a/doc/changelogs/CHANGELOG_V7.md b/doc/changelogs/CHANGELOG_V7.md
index 2e570801f0..1a0b989369 100644
--- a/doc/changelogs/CHANGELOG_V7.md
+++ b/doc/changelogs/CHANGELOG_V7.md
@@ -57,17 +57,17 @@ for details on patched vulnerabilities.
* **build**:
- Disable V8 snapshots - The hashseed embedded in the snapshot is
currently the same for all runs of the binary. This opens node up to
-collision attacks which could result in a Denial of Service. We have
-temporarily disabled snapshots until a more robust solution is found
-(Ali Ijaz Sheikh)
+ collision attacks which could result in a Denial of Service. We have
+ temporarily disabled snapshots until a more robust solution is found
+ (Ali Ijaz Sheikh)
* **deps**:
- CVE-2017-1000381 - The c-ares function ares_parse_naptr_reply(),
which is used for parsing NAPTR responses, could be triggered to
-read memory outside of the given input buffer if the passed in DNS
-response packet was crafted in a particular way. This patch checks that
-there is enough data for the required elements of an NAPTR record (2
-int16, 3 bytes for string lengths) before processing a record. (David
-Drysdale)
+ read memory outside of the given input buffer if the passed in DNS
+ response packet was crafted in a particular way. This patch checks that
+ there is enough data for the required elements of an NAPTR record (2
+ int16, 3 bytes for string lengths) before processing a record. (David
+ Drysdale)
### Commits
@@ -1552,7 +1552,7 @@ Thank you to @italoacasas for preparing the majority of this release.
* **buffer**:
- Reverted the runtime deprecation of calling `Buffer()` without `new`. (Anna Henningsen) [#9529](https://github.com/nodejs/node/pull/9529)
- Fixed `buffer.transcode()` for single-byte character
-encodings to `UCS2`. (Anna Henningsen) [#9838](https://github.com/nodejs/node/pull/9838)
+ encodings to `UCS2`. (Anna Henningsen) [#9838](https://github.com/nodejs/node/pull/9838)
* **promise**: `--trace-warnings` now produces useful stacktraces for Promise warnings. (Anna Henningsen) [#9525](https://github.com/nodejs/node/pull/9525)
* **repl**: Fixed a bug preventing correct parsing of generator functions. (Teddy Katz) [#9852](https://github.com/nodejs/node/pull/9852)
* **V8**: Fixed a significant `instanceof` performance regression. (Franziska Hinkelmann) [#9730](https://github.com/nodejs/node/pull/9730)
diff --git a/doc/guides/contributing/pull-requests.md b/doc/guides/contributing/pull-requests.md
index 3bb2b2d12f..ec6beb0bb5 100644
--- a/doc/guides/contributing/pull-requests.md
+++ b/doc/guides/contributing/pull-requests.md
@@ -159,8 +159,8 @@ A good commit message should describe what changed and why.
3. Wrap all other lines at 72 columns (except for long URLs).
4. If your patch fixes an open issue, you can add a reference to it at the end
-of the log. Use the `Fixes:` prefix and the full issue URL. For other references
-use `Refs:`.
+ of the log. Use the `Fixes:` prefix and the full issue URL. For other
+ references use `Refs:`.
Examples:
- `Fixes: https://github.com/nodejs/node/issues/1337`