summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRich Trott <rtrott@gmail.com>2017-12-02 01:26:35 -0800
committerRich Trott <rtrott@gmail.com>2017-12-03 20:12:45 -0800
commitf29992206807ca3c483301a88688f456cbcd3bf6 (patch)
treefd43b2ccabd4b5dc234896b549f6f843f6fba60f
parentf9660b71668c2edb20d13760a9a5bcbb76a20fbd (diff)
downloadandroid-node-v8-f29992206807ca3c483301a88688f456cbcd3bf6.tar.gz
android-node-v8-f29992206807ca3c483301a88688f456cbcd3bf6.tar.bz2
android-node-v8-f29992206807ca3c483301a88688f456cbcd3bf6.zip
test: remove fixturesDir from common module
Remove common.fixturesDir. All tests now use the the common/fixtures module instead. PR-URL: https://github.com/nodejs/node/pull/17400 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Lance Ball <lball@redhat.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
-rw-r--r--test/common/README.md5
-rw-r--r--test/common/index.js4
2 files changed, 1 insertions, 8 deletions
diff --git a/test/common/README.md b/test/common/README.md
index 30dd9a2f04..7fa47677ca 100644
--- a/test/common/README.md
+++ b/test/common/README.md
@@ -127,11 +127,6 @@ Returns a new promise that will propagate `promise` resolution or rejection if
that happens within the `timeoutMs` timespan, or rejects with `error` as
a reason otherwise.
-### fixturesDir
-* [&lt;String>]
-
-Path to the 'fixtures' directory.
-
### getArrayBufferViews(buf)
* `buf` [&lt;Buffer>]
* return [&lt;ArrayBufferView&#91;&#93;>]
diff --git a/test/common/index.js b/test/common/index.js
index fc3a055c1b..a78f900877 100644
--- a/test/common/index.js
+++ b/test/common/index.js
@@ -36,8 +36,6 @@ const testRoot = process.env.NODE_TEST_DIR ?
const noop = () => {};
-exports.fixturesDir = fixturesDir;
-
// Using a `.` prefixed name, which is the convention for "hidden" on POSIX,
// gets tools to ignore it by default or by simple rules, especially eslint.
let tmpDirName = '.tmp';
@@ -303,7 +301,7 @@ exports.childShouldThrowAndAbort = function() {
exports.ddCommand = function(filename, kilobytes) {
if (exports.isWindows) {
- const p = path.resolve(exports.fixturesDir, 'create-file.js');
+ const p = path.resolve(fixturesDir, 'create-file.js');
return `"${process.argv[0]}" "${p}" "${filename}" ${kilobytes * 1024}`;
} else {
return `dd if=/dev/zero of="${filename}" bs=1024 count=${kilobytes}`;