diff options
| author | JiaHerr Tee <jiaherrt@gmail.com> | 2018-02-08 18:38:38 -0500 |
|---|---|---|
| committer | Gus Caplan <me@gus.host> | 2018-02-09 18:20:08 -0600 |
| commit | edffad075e1dac0ebea7e70b05e4e49528fc59d2 (patch) | |
| tree | da828a4bfb482e03c42ac395cec7d1cb42cb2050 | |
| parent | 523a1550a3d07ecc3d13e071cb0f1c732bae3bad (diff) | |
| download | android-node-v8-edffad075e1dac0ebea7e70b05e4e49528fc59d2.tar.gz android-node-v8-edffad075e1dac0ebea7e70b05e4e49528fc59d2.tar.bz2 android-node-v8-edffad075e1dac0ebea7e70b05e4e49528fc59d2.zip | |
test: add url type check in Module options
The code coverage in `root/internal/vm/Module.js` lacked test coverage
for the url options paramter. The test adds a check to ensure error
is thrown.
PR-URL: https://github.com/nodejs/node/pull/18664
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
| -rw-r--r-- | test/parallel/test-vm-module-errors.js | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/test/parallel/test-vm-module-errors.js b/test/parallel/test-vm-module-errors.js index 1c7e01cf30..424d35e8aa 100644 --- a/test/parallel/test-vm-module-errors.js +++ b/test/parallel/test-vm-module-errors.js @@ -44,7 +44,7 @@ async function checkArgType() { }); for (const invalidOptions of [ - 0, 1, null, true, 'str', () => {}, Symbol.iterator + 0, 1, null, true, 'str', () => {}, { url: 0 }, Symbol.iterator ]) { common.expectsError(() => { new Module('', invalidOptions); |